Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show phpcr-bundle documentation #575

Merged
merged 1 commit into from
Apr 3, 2024
Merged

show phpcr-bundle documentation #575

merged 1 commit into from
Apr 3, 2024

Conversation

dbu
Copy link
Member

@dbu dbu commented Apr 3, 2024

i am adding the documentation in doctrine/DoctrinePHPCRBundle#399 - does that look correct?

@greg0ire greg0ire requested a review from SenseException April 3, 2024 11:10
@derrabus
Copy link
Member

derrabus commented Apr 3, 2024

Let's find out. 🙂

@derrabus derrabus merged commit 592a347 into doctrine:master Apr 3, 2024
5 checks passed
@dbu dbu deleted the add-phpcr-bundle branch April 3, 2024 11:25
@dbu
Copy link
Member Author

dbu commented Apr 3, 2024

hm, deploying fails https://github.com/doctrine/doctrine-website/actions/runs/8537711875/job/23388867200

what makes the process think there is a branch called master? i don't see a config for the default branch for e.g. DoctrineMigrationsBundle which also has no master branch.

@stof
Copy link
Member

stof commented Apr 3, 2024

This run was before the merge of doctrine/DoctrinePHPCRBundle@d3d19b6 adding the config file in the bundle.
Without a config file specifying versions, the website defaults to building a single version for the master branch:

private function createDefaultProjectData(string $repositoryName): array
{
$slug = str_replace('_', '-', $this->inflector->tableize($repositoryName));
return [
'name' => $repositoryName,
'repositoryName' => $repositoryName,
'docsPath' => $this->detectDocsPath($repositoryName),
'codePath' => $this->detectCodePath($repositoryName),
'slug' => $slug,
'versions' => [
[
'name' => 'master',
'branchName' => 'master',
'slug' => 'latest',
'aliases' => [
'current',
'stable',
],
],
],
];
}

@dbu
Copy link
Member Author

dbu commented Apr 3, 2024

ah, thats why.

should we trigger a rerun? how frequently is the website rebuilt?

@stof
Copy link
Member

stof commented Apr 3, 2024

Once a day by a cron + on every push to the master branch of this repo: https://github.com/doctrine/doctrine-website/blob/master/.github/workflows/deployment-prod.yml

@dbu
Copy link
Member Author

dbu commented Apr 4, 2024

seems to have worked, the bundle documentation is now online

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants