Modernize codebase for PHP 8 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/modernize
branch
4 times, most recently
from
2849735 to
dcedc55
Compare
derrabus
force-pushed
the
improvement/modernize
branch
from
dcedc55 to
bbed813
Compare
greg0ire
previously approved these changes
May 7, 2024
SenseException
previously approved these changes
May 7, 2024
derrabus
dismissed stale reviews from SenseException and greg0ire
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's modernize the codebase a little further and drop PHP 7 support. Since all classes in this repo are final, I believe that none of the changes is breaking. We could ship this a v1.4.
Marking as draft because we don't have a 1.4.x branch yet.Fixes #97 (review)