Parse "NOW()" like any other function

[mvorisek]

now() should not be parsed as one token, especially as it can be now( ) or now(6).

It should be parsed/formatted like any other (3 letter) function like xyz().

[mvorisek]

@derrabus can I please have your review here?

[derrabus]

Do we know why NOW() gets the special treatment currently that you're attempting to revert?

[mvorisek]

Based on git history this was introduced in jdorn/sql-formatter@e1aa999 and the PR title refers to jdorn/sql-formatter#47. I guess this was added for MySQL to format NOW() more like a value (single token), but as discussed above, this is not consistent with NOW( ) or NOW(6), or different function like COW(). So with this said, I am not aware of any specific purpose/past discussion outside this so it seems as a pure inconsistency for me.

[derrabus]

Makes sense to me.

[derrabus]

Can you please rebase? Our CI has changed significantly in 1.4.

[mvorisek]

Rebased but it seems you have to approve the CI again. Can you approve it for me for all (future) pushes to this repo/org?

[derrabus]

Can you approve it for me for all (future) pushes to this repo/org?

No. You need to have contributed successfully to this repo at least once. Then, GitHub won't ask for workflow approvals anymore.

[derrabus]

… which should be the case now. Try to rebase your other PRs and they should trigger the CI instantly.

[mvorisek]

Thank you!