Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -x test file permissions #103

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix -x test file permissions #103

merged 2 commits into from
May 13, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented May 13, 2024

also rename non-html test/fixture files to .txt

@mvorisek mvorisek marked this pull request as ready for review May 13, 2024 10:21
@mvorisek
Copy link
Contributor Author

mvorisek commented May 13, 2024

Also, not sure if you noticed:

PHPUnit 10.5.20 by Sebastian Bergmann and contributors.
Runtime:       PHP 8.3.7 with PCOV 1.0.11
Configuration: /home/runner/work/sql-formatter/sql-formatter/phpunit.xml.dist
R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R  63 / 243 ( 25%)
.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R. 126 / 243 ( 51%)
R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R 189 / 243 ( 77%)
.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R.R          243 / 243 (100%)
Time: 00:00.473, Memory: 26.00 MB
There were 122 risky tests:
1) Doctrine\SqlFormatter\Tests\SqlFormatterTest::testFormatHighlight with data set #0 ('SELECT customer_id, customer_... DESC;', '<pre style="color: black; bac...</pre>')
This test executed code that is not listed as code to be covered or used:
- Doctrine\SqlFormatter\Cursor
- Doctrine\SqlFormatter\HtmlHighlighter
- Doctrine\SqlFormatter\Token
- Doctrine\SqlFormatter\Tokenizer
/home/runner/work/sql-formatter/sql-formatter/tests/SqlFormatterTest.php:40

I am not gonna fix these, but it would be good to look at them as it seems not desired CI behaviour to me.

@derrabus
Copy link
Member

This test executed code that is not listed as code to be covered or used

I think we should stop annotating the expected coverage, tbh.

@derrabus derrabus added this to the 1.4.1 milestone May 13, 2024
@derrabus derrabus merged commit 63a6013 into doctrine:1.4.x May 13, 2024
10 checks passed
@mvorisek mvorisek deleted the fix-perm branch May 13, 2024 12:09
@mvorisek
Copy link
Contributor Author

@derrabus
Copy link
Member

Remove these https://github.com/doctrine/sql-formatter/blob/1.4.0/phpunit.xml.dist#L10-L11 lines?

Yes, and the corresponding attributes from the test classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants