Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert trigger bugs #2913

Merged
merged 6 commits into from
Apr 3, 2025
Merged

insert trigger bugs #2913

merged 6 commits into from
Apr 3, 2025

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Mar 26, 2025

fixes: dolthub/dolt#9039

Inserts nested inside triggers is a special case that we have minimal testing for. Some of the things that were broken before:

  • we did not prepend nodes inside trigger->insert blocks, so new columns were not accessible / the index offsets estimated based on prepending trigger rows were invalid
  • subqueries inside trigger->insert that have no outer visibility did not make exceptions for trigger rows, which act like lateral rows
  • prepending rules are flaky and mistakenly prepended in-between project->project nodes

Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-hoffman max-hoffman merged commit 893a99e into main Apr 3, 2025
7 of 8 checks passed
@max-hoffman max-hoffman deleted the max/trigger-join-prepend branch April 3, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger LEFT_JOIN indexing error
2 participants