Skip to content

Fix NULL default bug when merging branches with different schemas #9158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

Fix NULL default bug when merging branches with different schemas #9158

merged 1 commit into from
Apr 29, 2025

Conversation

macneale4
Copy link
Contributor

No description provided.

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d4450bc ok 5937457
version total_tests
d4450bc 5937457
correctness_percentage
100.0

@macneale4 macneale4 marked this pull request as ready for review April 29, 2025 00:04
@macneale4 macneale4 force-pushed the macneale4/merge-null-default branch from d4450bc to 82fc5c9 Compare April 29, 2025 01:17
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
82fc5c9 ok 5937457
version total_tests
82fc5c9 5937457
correctness_percentage
100.0

fulghum
fulghum approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@macneale4 macneale4 merged commit caba06c into main Apr 29, 2025
21 checks passed
@macneale4 macneale4 deleted the macneale4/merge-null-default branch April 29, 2025 15:47
@BrewTestBot BrewTestBot mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macneale4 @coffeegoddd @fulghum