Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix negative integer limits #2920

Merged
merged 9 commits into from
Apr 1, 2025
Merged

fix negative integer limits #2920

merged 9 commits into from
Apr 1, 2025

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Mar 31, 2025

In golang, the negation of the minimum int8, int16, int32, int64 is the same.

fix: dolthub/dolt#9053

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jycor jycor merged commit de24f91 into main Apr 1, 2025
8 checks passed
@jycor jycor deleted the james/negative branch April 1, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect negation of minimum signed integer
2 participants