Skip to content

fix NewServer call #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

srabraham
Copy link

this is a followup to #2989

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmu
Copy link
Member

zachmu commented May 28, 2025

Thanks for the contribution!

@srabraham
Copy link
Author

I'm not sure how this could break a test :S

this is a followup to dolthub#2989
@srabraham srabraham force-pushed the fix-newserver-readme branch from 09cde5c to a1946bc Compare June 3, 2025 16:28
@srabraham
Copy link
Author

Hey @zachmu , could you please have another look at this? It previously flaked in CI. I've rebased it on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants