Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid spin waits and dead connections in mysql server #406

Merged
merged 8 commits into from
Mar 24, 2025
Merged

Avoid spin waits and dead connections in mysql server #406

merged 8 commits into from
Mar 24, 2025

Conversation

macneale4
Copy link

Related (partial fix): dolthub/dolt#8943

@macneale4 macneale4 requested a review from zachmu as a code owner March 24, 2025 17:28
@macneale4 macneale4 mentioned this pull request Mar 24, 2025
Closed
@macneale4 macneale4 requested review from reltuk and removed request for zachmu March 24, 2025 17:47
reltuk
reltuk reviewed Mar 24, 2025
View reviewed changes
Copy link

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments. I think it's maybe simpler with the Add() and the optimistic sem send, but either way I think the references to local variables need to be cleaned up. In general these look like great improvements :).

@macneale4
Copy link
Author

got a ship it via chat with aaron.

@macneale4 macneale4 merged commit ee57ba9 into main Mar 24, 2025
4 checks passed
@macneale4 macneale4 mentioned this pull request Mar 25, 2025
Open
@BrewTestBot BrewTestBot mentioned this pull request Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reltuk reltuk reltuk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macneale4 @reltuk