Skip to content

Commit f2359b8

Browse files
dominicricodominicrico
committed
fixed expand offset
1 parent 84b1145 commit f2359b8

12 files changed

+89
-70
lines changed

‎coverage/PhantomJS 1.9.8 (Mac OS X 0.0.0)/lcov-report/index.html

+8-8
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
<div class="header low">
1616
<h1>Code coverage report for <span class="entity">All files</span></h1>
1717
<h2>
18-
Statements: <span class="metric">34.12% <small>(29 / 85)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
18+
Statements: <span class="metric">32.95% <small>(29 / 88)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
1919
Branches: <span class="metric">18.18% <small>(14 / 77)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
2020
Functions: <span class="metric">46.67% <small>(7 / 15)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
21-
Lines: <span class="metric">34.12% <small>(29 / 85)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
21+
Lines: <span class="metric">32.95% <small>(29 / 88)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
2222
Ignored: <span class="metric"><span class="ignore-none">none</span></span> &nbsp;&nbsp;&nbsp;&nbsp;
2323
</h2>
2424
<div class="path"></div>
@@ -42,23 +42,23 @@ <h2>
4242
</thead>
4343
<tbody><tr>
4444
<td class="file low" data-value="src/"><a href="src/index.html">src/</a></td>
45-
<td data-value="34.12" class="pic low"><span class="cover-fill" style="width: 34px;"></span><span class="cover-empty" style="width:66px;"></span></td>
46-
<td data-value="34.12" class="pct low">34.12%</td>
47-
<td data-value="85" class="abs low">(29&nbsp;/&nbsp;85)</td>
45+
<td data-value="32.95" class="pic low"><span class="cover-fill" style="width: 32px;"></span><span class="cover-empty" style="width:68px;"></span></td>
46+
<td data-value="32.95" class="pct low">32.95%</td>
47+
<td data-value="88" class="abs low">(29&nbsp;/&nbsp;88)</td>
4848
<td data-value="18.18" class="pct low">18.18%</td>
4949
<td data-value="77" class="abs low">(14&nbsp;/&nbsp;77)</td>
5050
<td data-value="46.67" class="pct low">46.67%</td>
5151
<td data-value="15" class="abs low">(7&nbsp;/&nbsp;15)</td>
52-
<td data-value="34.12" class="pct low">34.12%</td>
53-
<td data-value="85" class="abs low">(29&nbsp;/&nbsp;85)</td>
52+
<td data-value="32.95" class="pct low">32.95%</td>
53+
<td data-value="88" class="abs low">(29&nbsp;/&nbsp;88)</td>
5454
</tr>
5555

5656
</tbody>
5757
</table>
5858
</div>
5959
</div>
6060
<div class="footer">
61-
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jul 13 2015 15:27:06 GMT+0200 (CEST)</div>
61+
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jul 13 2015 15:44:43 GMT+0200 (CEST)</div>
6262
</div>
6363
<script src="prettify.js"></script>
6464
<script>

‎coverage/PhantomJS 1.9.8 (Mac OS X 0.0.0)/lcov-report/src/index.html

+8-8
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
<div class="header low">
1616
<h1>Code coverage report for <span class="entity">src/</span></h1>
1717
<h2>
18-
Statements: <span class="metric">34.12% <small>(29 / 85)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
18+
Statements: <span class="metric">32.95% <small>(29 / 88)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
1919
Branches: <span class="metric">18.18% <small>(14 / 77)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
2020
Functions: <span class="metric">46.67% <small>(7 / 15)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
21-
Lines: <span class="metric">34.12% <small>(29 / 85)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
21+
Lines: <span class="metric">32.95% <small>(29 / 88)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
2222
Ignored: <span class="metric"><span class="ignore-none">none</span></span> &nbsp;&nbsp;&nbsp;&nbsp;
2323
</h2>
2424
<div class="path"><a href="../index.html">All files</a> &#187; src/</div>
@@ -42,23 +42,23 @@ <h2>
4242
</thead>
4343
<tbody><tr>
4444
<td class="file low" data-value="ng-reading-indicator.js"><a href="ng-reading-indicator.js.html">ng-reading-indicator.js</a></td>
45-
<td data-value="34.12" class="pic low"><span class="cover-fill" style="width: 34px;"></span><span class="cover-empty" style="width:66px;"></span></td>
46-
<td data-value="34.12" class="pct low">34.12%</td>
47-
<td data-value="85" class="abs low">(29&nbsp;/&nbsp;85)</td>
45+
<td data-value="32.95" class="pic low"><span class="cover-fill" style="width: 32px;"></span><span class="cover-empty" style="width:68px;"></span></td>
46+
<td data-value="32.95" class="pct low">32.95%</td>
47+
<td data-value="88" class="abs low">(29&nbsp;/&nbsp;88)</td>
4848
<td data-value="18.18" class="pct low">18.18%</td>
4949
<td data-value="77" class="abs low">(14&nbsp;/&nbsp;77)</td>
5050
<td data-value="46.67" class="pct low">46.67%</td>
5151
<td data-value="15" class="abs low">(7&nbsp;/&nbsp;15)</td>
52-
<td data-value="34.12" class="pct low">34.12%</td>
53-
<td data-value="85" class="abs low">(29&nbsp;/&nbsp;85)</td>
52+
<td data-value="32.95" class="pct low">32.95%</td>
53+
<td data-value="88" class="abs low">(29&nbsp;/&nbsp;88)</td>
5454
</tr>
5555

5656
</tbody>
5757
</table>
5858
</div>
5959
</div>
6060
<div class="footer">
61-
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jul 13 2015 15:27:06 GMT+0200 (CEST)</div>
61+
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jul 13 2015 15:44:43 GMT+0200 (CEST)</div>
6262
</div>
6363
<script src="../prettify.js"></script>
6464
<script>

‎coverage/PhantomJS 1.9.8 (Mac OS X 0.0.0)/lcov-report/src/ng-reading-indicator.js.html

+15-6
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
<div class="header low">
1616
<h1>Code coverage report for <span class="entity">src/ng-reading-indicator.js</span></h1>
1717
<h2>
18-
Statements: <span class="metric">34.12% <small>(29 / 85)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
18+
Statements: <span class="metric">32.95% <small>(29 / 88)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
1919
Branches: <span class="metric">18.18% <small>(14 / 77)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
2020
Functions: <span class="metric">46.67% <small>(7 / 15)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
21-
Lines: <span class="metric">34.12% <small>(29 / 85)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
21+
Lines: <span class="metric">32.95% <small>(29 / 88)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
2222
Ignored: <span class="metric"><span class="ignore-none">none</span></span> &nbsp;&nbsp;&nbsp;&nbsp;
2323
</h2>
2424
<div class="path"><a href="../index.html">All files</a> &#187; <a href="index.html">src/</a> &#187; ng-reading-indicator.js</div>
@@ -214,7 +214,10 @@ <h2>
214214
187
215215
188
216216
189
217-
190</td><td class="line-coverage"><span class="cline-any cline-yes">1</span>
217+
190
218+
191
219+
192
220+
193</td><td class="line-coverage"><span class="cline-any cline-yes">1</span>
218221
<span class="cline-any cline-neutral">&nbsp;</span>
219222
<span class="cline-any cline-neutral">&nbsp;</span>
220223
<span class="cline-any cline-yes">1</span>
@@ -353,8 +356,11 @@ <h2>
353356
<span class="cline-any cline-no">&nbsp;</span>
354357
<span class="cline-any cline-no">&nbsp;</span>
355358
<span class="cline-any cline-no">&nbsp;</span>
359+
<span class="cline-any cline-no">&nbsp;</span>
356360
<span class="cline-any cline-neutral">&nbsp;</span>
357361
<span class="cline-any cline-no">&nbsp;</span>
362+
<span class="cline-any cline-no">&nbsp;</span>
363+
<span class="cline-any cline-no">&nbsp;</span>
358364
<span class="cline-any cline-neutral">&nbsp;</span>
359365
<span class="cline-any cline-neutral">&nbsp;</span>
360366
<span class="cline-any cline-neutral">&nbsp;</span>
@@ -534,16 +540,19 @@ <h2>
534540
<span class="cstat-no" title="statement not covered" > progressBar.style.width = progress + '%';</span>
535541
&nbsp;
536542
<span class="cstat-no" title="statement not covered" > if (options.expand) {</span>
537-
<span class="cstat-no" title="statement not covered" > if (scrollPos &gt; top &amp;&amp; scrollPos &lt; (expandOffset.top + options.topOffset)) {</span>
543+
<span class="cstat-no" title="statement not covered" > console.log(scrollPos, top, (expandOffset.top + options.topOffset) );</span>
544+
<span class="cstat-no" title="statement not covered" > if (scrollPos &gt; top &amp;&amp; scrollPos &lt; (top + expandOffset.top + options.topOffset)) {</span>
538545
<span class="cstat-no" title="statement not covered" > angular.element(element)[0].style.height = '5px';</span>
539546
<span class="cstat-no" title="statement not covered" > angular.element(element).addClass('ng-reading-indicator-shrink');</span>
540547
<span class="cstat-no" title="statement not covered" > angular.element(element).removeClass('ng-reading-indicator-expanded');</span>
541-
} else <span class="cstat-no" title="statement not covered" >if (scrollPos &gt;= (expandOffset.top + options.topOffset)) {</span>
548+
} else <span class="cstat-no" title="statement not covered" >if (scrollPos &gt;= (top + expandOffset.top + options.topOffset)) {</span>
542549
<span class="cstat-no" title="statement not covered" > angular.element(element).removeClass('ng-reading-indicator-shrink');</span>
543550
<span class="cstat-no" title="statement not covered" > angular.element(element).addClass('ng-reading-indicator-expanded');</span>
544551
<span class="cstat-no" title="statement not covered" > angular.element(element)[0].style.height = '';</span>
545552
}else {
546553
<span class="cstat-no" title="statement not covered" > angular.element(element)[0].style.height = '0';</span>
554+
<span class="cstat-no" title="statement not covered" > angular.element(element).addClass('ng-reading-indicator-shrink');</span>
555+
<span class="cstat-no" title="statement not covered" > angular.element(element).removeClass('ng-reading-indicator-expanded');</span>
547556
}
548557
}
549558
}
@@ -597,7 +606,7 @@ <h2>
597606

598607
</div>
599608
<div class="footer">
600-
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jul 13 2015 15:27:06 GMT+0200 (CEST)</div>
609+
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Jul 13 2015 15:44:43 GMT+0200 (CEST)</div>
601610
</div>
602611
<script src="../prettify.js"></script>
603612
<script>

‎coverage/PhantomJS 1.9.8 (Mac OS X 0.0.0)/lcov.info

+45-42
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ FN:80,(anonymous_9)
1212
FN:101,findEdges
1313
FN:112,updateSize
1414
FN:120,updateProgress
15-
FN:146,calculateReadingTime
16-
FN:171,(anonymous_14)
17-
FN:180,(anonymous_15)
15+
FN:149,calculateReadingTime
16+
FN:174,(anonymous_14)
17+
FN:183,(anonymous_15)
1818
FNF:15
1919
FNH:7
2020
FNDA:1,(anonymous_1)
@@ -93,31 +93,34 @@ DA:136,0
9393
DA:137,0
9494
DA:138,0
9595
DA:139,0
96-
DA:141,0
97-
DA:146,1
98-
DA:147,0
99-
DA:148,0
100-
DA:149,0
96+
DA:140,0
97+
DA:142,0
98+
DA:143,0
99+
DA:144,0
100+
DA:149,1
101101
DA:150,0
102+
DA:151,0
102103
DA:152,0
103104
DA:153,0
105+
DA:155,0
104106
DA:156,0
105-
DA:157,0
106107
DA:159,0
107108
DA:160,0
108-
DA:161,0
109109
DA:162,0
110+
DA:163,0
110111
DA:164,0
112+
DA:165,0
111113
DA:167,0
112-
DA:170,1
113-
DA:171,0
114-
DA:172,0
115-
DA:173,0
116-
DA:177,1
114+
DA:170,0
115+
DA:173,1
116+
DA:174,0
117+
DA:175,0
118+
DA:176,0
117119
DA:180,1
118-
DA:181,0
119-
DA:182,0
120-
LF:85
120+
DA:183,1
121+
DA:184,0
122+
DA:185,0
123+
LF:88
121124
LH:29
122125
BRDA:25,1,0,1
123126
BRDA:25,1,1,1
@@ -172,30 +175,30 @@ BRDA:126,24,0,0
172175
BRDA:126,24,1,0
173176
BRDA:131,25,0,0
174177
BRDA:131,25,1,0
175-
BRDA:132,26,0,0
176-
BRDA:132,26,1,0
177-
BRDA:132,27,0,0
178-
BRDA:132,27,1,0
179-
BRDA:136,28,0,0
180-
BRDA:136,28,1,0
181-
BRDA:152,29,0,0
182-
BRDA:152,29,1,0
183-
BRDA:152,30,0,0
184-
BRDA:152,30,1,0
185-
BRDA:156,31,0,0
186-
BRDA:156,31,1,0
187-
BRDA:159,32,0,0
188-
BRDA:159,32,1,0
189-
BRDA:161,33,0,0
190-
BRDA:161,33,1,0
191-
BRDA:170,34,0,0
192-
BRDA:170,34,1,1
193-
BRDA:170,35,0,1
194-
BRDA:170,35,1,0
195-
BRDA:172,36,0,0
196-
BRDA:172,36,1,0
197-
BRDA:172,37,0,0
198-
BRDA:172,37,1,0
178+
BRDA:133,26,0,0
179+
BRDA:133,26,1,0
180+
BRDA:133,27,0,0
181+
BRDA:133,27,1,0
182+
BRDA:137,28,0,0
183+
BRDA:137,28,1,0
184+
BRDA:155,29,0,0
185+
BRDA:155,29,1,0
186+
BRDA:155,30,0,0
187+
BRDA:155,30,1,0
188+
BRDA:159,31,0,0
189+
BRDA:159,31,1,0
190+
BRDA:162,32,0,0
191+
BRDA:162,32,1,0
192+
BRDA:164,33,0,0
193+
BRDA:164,33,1,0
194+
BRDA:173,34,0,0
195+
BRDA:173,34,1,1
196+
BRDA:173,35,0,1
197+
BRDA:173,35,1,0
198+
BRDA:175,36,0,0
199+
BRDA:175,36,1,0
200+
BRDA:175,37,0,0
201+
BRDA:175,37,1,0
199202
BRF:77
200203
BRH:14
201204
end_of_record

0 commit comments

Comments
 (0)