url: Fixed pathname setter, throw when parsing http, ftp, ws URLs without host or path.

Author: dop251

url/testdata/url_test.js

@@ -88,6 +88,7 @@ assert.sameValue(myURL.href, "https://abc:123@example.com/");
 myURL = new URL("https://example.org/abc/xyz?123");
 myURL.pathname = "/abcdef";
 assert.sameValue(myURL.href, "https://example.org/abcdef?123");
+assert.sameValue(myURL.toString(), "https://example.org/abcdef?123");
 
 myURL.pathname = "";
 assert.sameValue(myURL.href, "https://example.org/?123");
@@ -96,6 +97,32 @@ myURL.pathname = "á";
 assert.sameValue(myURL.pathname, "/%C3%A1");
 assert.sameValue(myURL.href, "https://example.org/%C3%A1?123");
 
+myURL = new URL("file:///./abc");
+assert.sameValue(myURL.pathname, "/abc");
+
+myURL = new URL("fish://host/.");
+assert.sameValue(myURL.pathname, "/");
+myURL.pathname = ".";
+assert.sameValue(myURL.pathname, "/");
+
+myURL = new URL("fish://host/a/../b");
+assert.sameValue(myURL.pathname, '/b');
+myURL.pathname = 'a/../c';
+assert.sameValue(myURL.pathname, '/c');
+
+myURL = new URL("file://");
+assert.sameValue(myURL.pathname, "/");
+assert.sameValue(myURL.href, "file:///");
+
+assert.throwsNodeError(() => {
+    new URL("http://");
+}, TypeError, "ERR_INVALID_URL");
+
+// myURL = new URL("fish://");
+// assert.sameValue(myURL.pathname, "");
+// Currently returns "fish:"
+// assert.sameValue(myURL.href, "fish://");
+
 // port
 
 myURL = new URL("https://example.org:8888");
@@ -227,3 +254,9 @@ assert.sameValue(myURL.toString(), "https://example.com/?first=one");
     assert.sameValue(url.domainToUnicode('xn--fiq228c.com'), "中文.com");
     assert.sameValue(url.domainToUnicode('xn--iñvalid.com'), "");
 }
+
+{
+    const url = new URL("otpauth://totp");
+    url.pathname = 'domain.com Domain:user@domain.com';
+    assert.sameValue(url.toString(), 'otpauth://totp/domain.com%20Domain:user@domain.com');
+}

url/url.go

@@ -3,6 +3,7 @@ package url
 import (
 	"math"
 	"net/url"
+	"path"
 	"reflect"
 	"strconv"
 	"strings"
@@ -131,6 +132,14 @@ func isSpecialProtocol(protocol string) bool {
 	return false
 }
 
+func isSpecialNetProtocol(protocol string) bool {
+	switch protocol {
+	case "https", "http", "ftp", "wss", "ws":
+		return true
+	}
+	return false
+}
+
 func clearURLPort(u *url.URL) {
 	u.Host = u.Hostname()
 }
@@ -167,6 +176,9 @@ func (m *urlModule) parseURL(s string, isBase bool) *url.URL {
 	if isBase && !u.IsAbs() {
 		panic(m.newInvalidURLError(URLNotAbsolute, s))
 	}
+	if isSpecialNetProtocol(u.Scheme) && u.Host == "" && u.Path == "" {
+		panic(m.newInvalidURLError(InvalidURL, s))
+	}
 	if portStr := u.Port(); portStr != "" {
 		if port, err := strconv.Atoi(portStr); err != nil || isDefaultURLPort(u.Scheme, port) {
 			u.Host = u.Hostname() // Clear port
@@ -182,12 +194,19 @@ func fixRawQuery(u *url.URL) {
 	}
 }
 
+func cleanPath(p, proto string) string {
+	if !strings.HasPrefix(p, "/") && (isSpecialProtocol(proto) || p != "") {
+		p = "/" + p
+	}
+	if p != "" {
+		return path.Clean(p)
+	}
+	return ""
+}
+
 func (m *urlModule) fixURL(u *url.URL) {
-	switch u.Scheme {
-	case "https", "http", "ftp", "wss", "ws":
-		if u.Path == "" {
-			u.Path = "/"
-		}
+	u.Path = cleanPath(u.Path, u.Scheme)
+	if isSpecialNetProtocol(u.Scheme) {
 		hostname := u.Hostname()
 		lh := strings.ToLower(hostname)
 		ch, err := idna.Punycode.ToASCII(lh)
@@ -262,16 +281,7 @@ func (m *urlModule) createURLPrototype() *goja.Object {
 	m.defineURLAccessorProp(p, "pathname", func(u *nodeURL) interface{} {
 		return u.url.EscapedPath()
 	}, func(u *nodeURL, arg goja.Value) {
-		p := arg.String()
-		if _, err := url.Parse(p); err == nil {
-			switch u.url.Scheme {
-			case "https", "http", "ftp", "ws", "wss":
-				if !strings.HasPrefix(p, "/") {
-					p = "/" + p
-				}
-			}
-			u.url.Path = p
-		}
+		u.url.Path = cleanPath(arg.String(), u.url.Scheme)
 	})
 
 	// origin