Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a comment on read_dora_input_id #580

Merged
merged 3 commits into from
Jul 11, 2024
Merged

add a comment on read_dora_input_id #580

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e590b2e
add a comment on read_dora_input_id
XxChang Jul 9, 2024
8ee80ca
fix fmt
XxChang Jul 9, 2024
2e426e5
add safety
XxChang Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apis/c/node/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,12 @@
///
/// The `event` argument must be a dora event received through
/// [`dora_next_event`]. The event must be still valid, i.e., not
/// freed yet. The returned `out_ptr` must not be used after

Check failure on line 122 in apis/c/node/src/lib.rs

View workflow job for this annotation

GitHub Actions / Formatting 

Diff in /home/runner/work/dora/dora/apis/c/node/src/lib.rs
/// freeing the `event`, since it points directly into the event's
/// memory.
///
/// Note: `Out_ptr` is not a null-terminated string. The length of the string
/// is given by `out_len`.
#[no_mangle]
pub unsafe extern "C" fn read_dora_input_id(
event: *const (),
Expand Down
Loading