-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conventional middleware class requirements. #12895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work ...
Update the ms.date
on Line 7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit.
Version the whole topic for 2.1+ (1.1 is about to go away, and 2.0 has already left the scene). In the metadata between
|
@guardrex Thanks for such prompt feedback. 🚀 I've (hopefully) made the relevant changes, as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ I'm lov'in IT!™️
"I'm lov'in IT!" is a registered trademark of the McDonald's Corporation. 😄
Let's go ahead and not disturb cats OOF. 🏖 |
Fixes #11443.
I made a few changes here:
async
/await
to match the approach used in the middleware class.TODO:
I don't know how to test the moniker ranges locally, so I couldn't update the note about
InvokeAsync
being available in ASP.NET Core 2.0+. Ideally, I'd like to know how to test this locally but alternatively, please make the relevant change. I imagine this being a different version of the relevant bullet for < 2.0, e.g.: