Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Fix too early stream close and several other bugs in StackParser #61

Merged
merged 3 commits into from
Feb 28, 2017
Merged

Fix too early stream close and several other bugs in StackParser #61

merged 3 commits into from
Feb 28, 2017

Conversation

schuettecarsten
Copy link
Contributor

@schuettecarsten schuettecarsten commented Feb 22, 2017 •
edited
Loading

This PR fixes three problems:

  • The StreamReader/StreamWriter that are used to access /in and /out files, are closed too early (StackParser crashes when using /in and /out parameter #60)
  • Fix a bug where the first character of a module name is lost if the first fragment of a stack trace line does not contain a space
  • Fix problem when PDB file name has different case in command line parameter, PDB and module name can be handled as case-insensitive in the dictionaries

Please review. Thanks.

@schuettecarsten schuettecarsten changed the title Fix too early stream close and several other bugs Fix too early stream close and several other bugs in StackParser. Feb 22, 2017
@schuettecarsten schuettecarsten changed the title Fix too early stream close and several other bugs in StackParser. Fix too early stream close and several other bugs in StackParser Feb 22, 2017
@MattWhilden
Copy link
Contributor

LGTM. Thanks for posting these back.

@MattWhilden MattWhilden merged commit 2a313bb into dotnet:master Feb 28, 2017
@schuettecarsten schuettecarsten deleted the pr/FixStreamCloseAndSeveralBugs branch March 10, 2017 20:59
@Trolldemorted Trolldemorted mentioned this pull request Aug 3, 2018
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schuettecarsten @MattWhilden