Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic port support to all diagnostic tools #5250

Open
maskati opened this issue Feb 12, 2025 · 3 comments
Open

Add diagnostic port support to all diagnostic tools #5250

maskati opened this issue Feb 12, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@maskati
Copy link

maskati commented Feb 12, 2025

Background and Motivation

Currently it seems only dotnet-trace and dotnet-counters support the --diagnostic-port parameter. Documentation incorrectly states that diagnostic port is supported as a parameter to dotnet-dump.

This limits tooling to scenarios with shared process namespace and requires us to configure a separate listener such as dotnet-monitor. It would be useful to be able to use diagnostic tooling in scenarios with only shared diagnostic port socket (e.g. shared emptyDir between containers).

Since we can now connect to diagnostic ports using DiagnosticClient is there a reason this capability is not available in all tooling such as dotnet-dump?

Proposed Feature

Add --diagnostic-port support to tooling where it is supported by DiagnosticClient.

Usage Examples

dotnet-dump collect --diagnostic-port /tmp/dotnet-diagnostic-1-23456-socket,connect

@maskati maskati added the enhancement New feature or request label Feb 12, 2025
@hoyosjs
Copy link
Member

hoyosjs commented Feb 12, 2025

This is #3877

@hoyosjs
Copy link
Member

hoyosjs commented Feb 12, 2025

Is your proposed solution to mount tmp and then use that?

@maskati
Copy link
Author

maskati commented Feb 13, 2025

@hoyosjs yes, I would like to mount tmp and connect to the default diagnostic port from outside the target process namespace. #3877 is exactly what I am looking for in dotnet-dump. In addition it would also be great to have the same support in dotnet-gcdump and dotnet-stack 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants