Launch dsrouter from dotnet-trace #5241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lateralusX
reviewed
Feb 11, 2025
lateralusX
reviewed
Feb 11, 2025
lateralusX
reviewed
Feb 11, 2025
lateralusX
reviewed
Feb 11, 2025
lateralusX
reviewed
Feb 11, 2025
lateralusX
reviewed
Feb 11, 2025
lateralusX
reviewed
Feb 11, 2025
noahfalk
reviewed
Feb 11, 2025
|
fyi @dotnet/dotnet-diag |
StephaneDelcroix
force-pushed
the
trace-dsrouter
branch
3 times, most recently
from
127755e to
90dba68
Compare
This PR aim to simplify the process of collecting traces for maui mobile scenarios and reduce the number of steps for simple cases (when a dsrouter isn't already running). It adds a --dsrouter option to collect that takes one of the following values: android, android-emu, ios, ios-sim This doesn't make dotnet-trace depends on dotnet-dsrouter, the option checks for the existence of dsrotuer in the same path as trace, and invokes it.
StephaneDelcroix
force-pushed
the
trace-dsrouter
branch
from
2c2f039 to
d20e725
Compare
lateralusX
approved these changes
Feb 12, 2025
jonathanpeppers
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to simplify the process of collecting traces for maui mobile scenarios and reduce the number of steps for simple cases (when a dsrouter isn't already running).
It adds a --dsrouter option to collect that takes one of the following values: android, android-emu, ios, ios-sim
This doesn't make dotnet-trace depends on dotnet-dsrouter, the option checks for the existence of dsrotuer in the same path as trace, and invokes it.