Skip to content

chore: Add dedicated environment for release.yml workflow #10673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented May 19, 2025

This PR intended to isolate release.yml workflow with other workflows.
It's required because release.yml using secrets. that should not be exposed to public.

Required steps before running updated release workflow

  1. Create new release environment at https://github.com/dotnet/docfx/settings/environments
  2. Create new secrets for NuGet package sign/publish.
  3. Register new secrets to release environment
  4. Invalidate old secrets. And remove secrets from other environments/repository.

@yufeih yufeih requested a review from Copilot May 21, 2025 09:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR isolates the release workflow by adding a dedicated environment to better manage secrets.

  • Added "environment: release" field to the release.yml workflow.
  • Ensured that the release process uses new secrets and is segregated from other workflows.

@filzrev filzrev force-pushed the chore-add-dedicated-environment-for-release-workflow branch from 7cfd220 to eb0ed91 Compare May 27, 2025 11:01
@filzrev filzrev force-pushed the chore-add-dedicated-environment-for-release-workflow branch from eb0ed91 to 5a1b375 Compare May 30, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant