-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Updated Tensorflow.Net to 0.70.2 with Tensorflow 2.7.0. #7472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
NumSharp replaced with Tensorflow.NumPy. TensorShape replaced with Shape, Shape object has dimensions as 64 bit long, check added for casting to 32 bit int alsoTensor constructor using SafeTensorHandle/DangerousGetHandle and TF_DataType not required when casting. Added StringTensorFactory to wrap addition tensorflow.dll methods required to create Tensors from string based input.
@dotnet-policy-service agree |
CI failing is interesting, I wonder if the dotnet9.0 runtime needs to be included in the initial build steps? I installed the runtime manually to the |
Continuing CI issues, without access to logs we're limited in how far we can proceed with fixes. |
/azp run MachineLearning-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
Sorry for the delay here, I'll have a look and see what failures you're hitting and figure out how we can get this working. Thank you for your contribution - this update is something we've wanted to get in. |
CI failures are all due to packages not mirrored to our build feeds. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1066692&view=logs&j=80b813b5-9a08-5859-11a8-dc0e5b556e52&t=99848337-6ccc-53eb-9c14-1b676ae001b9
Let me help get those mirrored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully we get better build results now. We'll need to decide on final version.
@@ -90,6 +90,7 @@ | |||
<BenchmarkDotNetVersion>0.13.12</BenchmarkDotNetVersion> | |||
<DotNetRuntime60Version>6.0.36</DotNetRuntime60Version> | |||
<DotNetRuntime80Version>8.0.16</DotNetRuntime80Version> | |||
<DotNetRuntime90Version>9.0.5</DotNetRuntime90Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be required. I don't see anything using net9.0
in this PR. We would only need to do this if we had tools that needed to run on .NET 9.0, or wanted to test against .NET 9.0 on the build machine.
@@ -67,9 +67,9 @@ | |||
<ParquetDotNetVersion>2.1.3</ParquetDotNetVersion> | |||
<PlotlyNETCSharpVersion>0.11.1</PlotlyNETCSharpVersion> | |||
<SharpZipLibVersion>1.4.2</SharpZipLibVersion> | |||
<TensorflowDotNETVersion>0.20.1</TensorflowDotNETVersion> | |||
<TensorflowDotNETVersion>0.70.2</TensorflowDotNETVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this version and not latest (0.150.01
)? Was there an issue with the latest package?
<TensorFlowMajorVersion>2</TensorFlowMajorVersion> | ||
<TensorFlowVersion>2.3.1</TensorFlowVersion> | ||
<TensorFlowVersion>2.7.0</TensorFlowVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar question could we use newer TensorFlow packages?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7472 +/- ##
==========================================
+ Coverage 68.99% 69.00% +0.01%
==========================================
Files 1482 1482
Lines 273880 273921 +41
Branches 28254 28258 +4
==========================================
+ Hits 188956 189020 +64
+ Misses 77540 77517 -23
Partials 7384 7384
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes #7471
NumSharp replaced with Tensorflow.NumPy.
TensorShape replaced with Shape, Shape object has dimensions as 64 bit long, check added for casting to 32 bit int alsoTensor constructor using SafeTensorHandle/DangerousGetHandle and TF_DataType not required when casting.
Added StringTensorFactory to wrap addition tensorflow.dll methods required to create Tensors from string based input.
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged.