[Testing] Enabling more UI Tests by removing platform specific condition - 3 #27501

LogishaSelvarajSF4525 · 2025-01-31T14:52:17Z

Description of Change

The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 3rd group of tests enabled.

Test Cases:

Issue21173
Issue21202
Issue21314
Issue21394
Issue21437
Issue21706
Issue21787
Issue22042
Issue22183
Issue2241
Issue22606
Issue22630
Issue22750
Issue22937
Issue4484

Fixes #22902

Copilot reviewed 18 out of 29 changed files in this pull request and generated no comments.

Files not reviewed (11)

src/Controls/tests/TestCases.HostApp/Issues/Issue22630.xaml: Language not supported
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21173.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22042.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21394.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21202.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21314.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22183.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22937.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22750.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21787.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21706.cs: Evaluated as low risk

Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue2241.cs:1

[nitpick] The comment could be clearer: 'The test fails on Windows and MacCatalyst because the SetOrientation method is only supported on mobile platforms (iOS and Android).'

#if IOS || ANDROID  //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms iOS and Android.

jsuarezruiz · 2025-02-03T06:52:59Z

/azp run

azure-pipelines · 2025-02-03T06:53:21Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-03T08:18:26Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21173.cs

@@ -12,7 +12,6 @@ public Issue21173(TestDevice device)
 		: base(device)
 	{ }

-#if ANDROID
 	[Test]
 	[Category(UITestCategories.Border)]
 	public void BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt()


This test is failing on Windows:

at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2311 at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2326 at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 663 at Microsoft.Maui.TestCases.Tests.Issues.Issue21173.BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21173.cs:line 19 at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor) at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Modified the test to ensure it runs on Windows and committed the code changes.

Nice! The snapshot on Windows is pending and available on the latest build.

jsuarezruiz · 2025-02-03T08:19:10Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22183.cs

@@ -1,5 +1,4 @@
-#if IOS
-using NUnit.Framework;
+using NUnit.Framework;


Pending snapshots. Already available on the latest build.

I have committed this snapshot in the latest changes.

jsuarezruiz · 2025-02-04T07:10:20Z

/azp run

azure-pipelines · 2025-02-04T07:10:43Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-04T11:11:13Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22750.cs

@@ -28,5 +27,4 @@ public void RadioButtonUpdateValueInsideBorder()
 			VerifyScreenshot("RadioButtonUpdateValueInsideBorderYes");


Pending snapshot on macOS.

The images generated for Mac from this CI have not proper, Could we attempt to retrigger the CI for this?

Build failing because the test is pending:

Attached it.

jsuarezruiz · 2025-02-04T11:12:41Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21173.cs

@@ -12,7 +12,6 @@ public Issue21173(TestDevice device)
 		: base(device)
 	{ }

-#if ANDROID
 	[Test]
 	[Category(UITestCategories.Border)]
 	public void BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt()


Nice! The snapshot on Windows is pending and available on the latest build.

jsuarezruiz · 2025-02-04T11:14:39Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22937.cs

@@ -23,5 +22,4 @@ public void ToolbarItemFontColorDynamicUpdate()
 			VerifyScreenshot();


Pending snapshot on Mac.

The images generated for Mac from this CI have not proper, Could we attempt to retrigger the CI for this?

Better wait to #27531

jsuarezruiz · 2025-02-07T09:40:54Z

/azp run

azure-pipelines · 2025-02-07T09:41:16Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

We've changed the logic for taking screenshots on macOS. It has been optimized, now instead of setting the App to full screen and taking the screenshot, we directly get the Window position and size and create a snapshot by cropping the App's content from the screen.

This requires re-committing the updated macOS screenshots.

Example:

Issue21394Test

LogishaSelvarajSF4525 · 2025-02-10T10:49:57Z

We've changed the logic for taking screenshots on macOS. It has been optimized, now instead of setting the App to full screen and taking the screenshot, we directly get the Window position and size and create a snapshot by cropping the App's content from the screen.

This requires re-committing the updated macOS screenshots.

Example:

Issue21394Test

I have updated the current Mac snapshots to reflect the latest changes.

jsuarezruiz · 2025-02-11T07:29:10Z

/azp run

azure-pipelines · 2025-02-11T07:29:30Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-11T12:05:49Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22750.cs

@@ -28,5 +27,4 @@ public void RadioButtonUpdateValueInsideBorder()
 			VerifyScreenshot("RadioButtonUpdateValueInsideBorderYes");


Build failing because the test is pending:

Attached it.

LogishaSelvarajSF4525 · 2025-02-12T07:13:07Z

@jsuarezruiz I have updated the current Mac snapshots to reflect the latest changes.

mattleibow · 2025-02-12T10:36:12Z

/azp run

azure-pipelines · 2025-02-12T10:36:33Z

Azure Pipelines successfully started running 3 pipeline(s).

LogishaSelvarajSF4525 added 5 commits January 30, 2025 19:36

enable test cases for all platforms

5af3b2b

added the snapshot for issues

4b7c217

update the changes

ce3f4d4

revert the issue22630 and issue11869

d906cdb

enable the issue22630 for all platforms

fded2b2

LogishaSelvarajSF4525 added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jan 31, 2025

dotnet-policy-service bot added the community ✨ Community Contribution label Jan 31, 2025

LogishaSelvarajSF4525 marked this pull request as ready for review February 3, 2025 06:04

Copilot bot review requested due to automatic review settings February 3, 2025 06:04

LogishaSelvarajSF4525 requested a review from a team as a code owner February 3, 2025 06:04

LogishaSelvarajSF4525 requested review from mattleibow and tj-devel709 February 3, 2025 06:04

Merge branch 'dotnet:main' into logi-enableuitests8

a628168

Copilot AI reviewed Feb 3, 2025

View reviewed changes

jsuarezruiz requested changes Feb 3, 2025

View reviewed changes

LogishaSelvarajSF4525 added 2 commits February 3, 2025 18:43

added a snapshot for issues

69dd923

Merge branch 'dotnet:main' into logi-enableuitests8

89055ac

jsuarezruiz requested changes Feb 4, 2025

View reviewed changes

LogishaSelvarajSF4525 added 4 commits February 4, 2025 18:21

added a snap

586e272

Merge branch 'dotnet:main' into logi-enableuitests8

998f601

Merge branch 'dotnet:main' into logi-enableuitests8

38fd070

Merge branch 'dotnet:main' into logi-enableuitests8

6c8a0a9

jsuarezruiz requested changes Feb 7, 2025

View reviewed changes

LogishaSelvarajSF4525 added 2 commits February 10, 2025 11:40

replace snapshots

e0b674c

Merge branch 'dotnet:main' into logi-enableuitests8

55c3236

jsuarezruiz requested changes Feb 11, 2025

View reviewed changes

LogishaSelvarajSF4525 added 2 commits February 12, 2025 11:37

replace the latest snapshot

2db0ad1

Merge branch 'dotnet:main' into logi-enableuitests8

e99c8a3

jsuarezruiz approved these changes Feb 13, 2025

View reviewed changes

jfversluis merged commit dc4af6c into dotnet:main Feb 13, 2025
123 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Testing] Enabling more UI Tests by removing platform specific condition - 3 #27501

[Testing] Enabling more UI Tests by removing platform specific condition - 3 #27501

LogishaSelvarajSF4525 commented Jan 31, 2025

jsuarezruiz commented Feb 3, 2025

azure-pipelines bot commented Feb 3, 2025

jsuarezruiz Feb 3, 2025

LogishaSelvarajSF4525 Feb 3, 2025

jsuarezruiz Feb 4, 2025

jsuarezruiz Feb 3, 2025

LogishaSelvarajSF4525 Feb 3, 2025

jsuarezruiz commented Feb 4, 2025

azure-pipelines bot commented Feb 4, 2025

jsuarezruiz Feb 4, 2025

LogishaSelvarajSF4525 Feb 5, 2025

jsuarezruiz Feb 11, 2025

jsuarezruiz Feb 4, 2025

jsuarezruiz Feb 4, 2025

LogishaSelvarajSF4525 Feb 5, 2025

jsuarezruiz Feb 5, 2025

jsuarezruiz commented Feb 7, 2025

azure-pipelines bot commented Feb 7, 2025

jsuarezruiz left a comment

LogishaSelvarajSF4525 commented Feb 10, 2025

jsuarezruiz commented Feb 11, 2025

azure-pipelines bot commented Feb 11, 2025

jsuarezruiz Feb 11, 2025

LogishaSelvarajSF4525 commented Feb 12, 2025

mattleibow commented Feb 12, 2025

azure-pipelines bot commented Feb 12, 2025

		@@ -28,5 +27,4 @@ public void RadioButtonUpdateValueInsideBorder()
		VerifyScreenshot("RadioButtonUpdateValueInsideBorderYes");

		@@ -23,5 +22,4 @@ public void ToolbarItemFontColorDynamicUpdate()
		VerifyScreenshot();

[Testing] Enabling more UI Tests by removing platform specific condition - 3 #27501

[Testing] Enabling more UI Tests by removing platform specific condition - 3 #27501

Conversation

LogishaSelvarajSF4525 commented Jan 31, 2025

Description of Change

Test Cases:

Choose a reason for hiding this comment

jsuarezruiz commented Feb 3, 2025

azure-pipelines bot commented Feb 3, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsuarezruiz commented Feb 4, 2025

azure-pipelines bot commented Feb 4, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsuarezruiz commented Feb 7, 2025

azure-pipelines bot commented Feb 7, 2025

jsuarezruiz left a comment

Choose a reason for hiding this comment

LogishaSelvarajSF4525 commented Feb 10, 2025

jsuarezruiz commented Feb 11, 2025

azure-pipelines bot commented Feb 11, 2025

Choose a reason for hiding this comment

LogishaSelvarajSF4525 commented Feb 12, 2025

mattleibow commented Feb 12, 2025

azure-pipelines bot commented Feb 12, 2025