-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Enabling more UI Tests by removing platform specific condition - 3 #27501
Changes from all commits
5af3b2b
4b7c217
ce3f4d4
d906cdb
fded2b2
a628168
69dd923
89055ac
586e272
998f601
38fd070
6c8a0a9
e0b674c
55c3236
2db0ad1
e99c8a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
#if IOS | ||
using NUnit.Framework; | ||
using NUnit.Framework; | ||
using UITest.Appium; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pending snapshots. Already available on the latest build. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have committed this snapshot in the latest changes. |
||
using UITest.Core; | ||
|
||
|
@@ -29,4 +28,3 @@ public void RadioButtonWithValueChangeSelected() | |
} | ||
} | ||
} | ||
#endif |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
#if ANDROID | ||
using NUnit.Framework; | ||
using NUnit.Framework; | ||
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
|
@@ -28,5 +27,4 @@ public void RadioButtonUpdateValueInsideBorder() | |
VerifyScreenshot("RadioButtonUpdateValueInsideBorderYes"); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pending snapshot on macOS. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The images generated for Mac from this CI have not proper, Could we attempt to retrigger the CI for this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
} | ||
#endif | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
#if ANDROID || WINDOWS | ||
using NUnit.Framework; | ||
using NUnit.Framework; | ||
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
|
@@ -23,5 +22,4 @@ public void ToolbarItemFontColorDynamicUpdate() | |
VerifyScreenshot(); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pending snapshot on Mac. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The images generated for Mac from this CI have not proper, Could we attempt to retrigger the CI for this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Better wait to #27531 |
||
} | ||
} | ||
#endif | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing on Windows:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the test to ensure it runs on Windows and committed the code changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The snapshot on Windows is pending and available on the latest build.