Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Enabling more UI Tests by removing platform specific condition - 3 #27501

Merged
merged 16 commits into from
Feb 13, 2025
Merged

[Testing] Enabling more UI Tests by removing platform specific condition - 3 #27501

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5af3b2b
enable test cases for all platforms
LogishaSelvarajSF4525 Jan 30, 2025
4b7c217
added the snapshot for issues
LogishaSelvarajSF4525 Jan 31, 2025
ce3f4d4
update the changes
LogishaSelvarajSF4525 Jan 31, 2025
d906cdb
revert the issue22630 and issue11869
LogishaSelvarajSF4525 Jan 31, 2025
fded2b2
enable the issue22630 for all platforms
LogishaSelvarajSF4525 Jan 31, 2025
a628168
Merge branch 'dotnet:main' into logi-enableuitests8
LogishaSelvarajSF4525 Feb 3, 2025
69dd923
added a snapshot for issues
LogishaSelvarajSF4525 Feb 3, 2025
89055ac
Merge branch 'dotnet:main' into logi-enableuitests8
LogishaSelvarajSF4525 Feb 3, 2025
586e272
added a snap
LogishaSelvarajSF4525 Feb 4, 2025
998f601
Merge branch 'dotnet:main' into logi-enableuitests8
LogishaSelvarajSF4525 Feb 4, 2025
38fd070
Merge branch 'dotnet:main' into logi-enableuitests8
LogishaSelvarajSF4525 Feb 6, 2025
6c8a0a9
Merge branch 'dotnet:main' into logi-enableuitests8
LogishaSelvarajSF4525 Feb 7, 2025
e0b674c
replace snapshots
LogishaSelvarajSF4525 Feb 10, 2025
55c3236
Merge branch 'dotnet:main' into logi-enableuitests8
LogishaSelvarajSF4525 Feb 10, 2025
2db0ad1
replace the latest snapshot
LogishaSelvarajSF4525 Feb 12, 2025
e99c8a3
Merge branch 'dotnet:main' into logi-enableuitests8
LogishaSelvarajSF4525 Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added ...s/TestCases.Android.Tests/snapshots/android/ImageButtonStuckAfterRightClick.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue21202Test.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue21394Test.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...s/tests/TestCases.Android.Tests/snapshots/android/LabelTextDecorationsWorks.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...estCases.Android.Tests/snapshots/android/RadioButtonWithValueChangeSelected.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion src/Controls/tests/TestCases.HostApp/Issues/Issue22630.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@
<Label
x:Name="TestLabel"
AutomationId="TestLabel" />
<!-- Set the RowHeight to enable scrolling on the Windows platform -->
<ListView
AutomationId="TestListView"
Grid.Row="1"
Grid.Row="1" RowHeight="40"
Scrolled="OnListViewScrolled">
<ListView.ItemsSource>
<x:Array Type="{x:Type x:String}">
Expand Down
2 changes: 0 additions & 2 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21173.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ public Issue21173(TestDevice device)
: base(device)
{ }

#if ANDROID
[Test]
[Category(UITestCategories.Border)]
public void BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing on Windows:

   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2311
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2326
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 663
   at Microsoft.Maui.TestCases.Tests.Issues.Issue21173.BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21173.cs:line 19
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the test to ensure it runs on Windows and committed the code changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The snapshot on Windows is pending and available on the latest build.

Expand All @@ -22,5 +21,4 @@ public void BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt()
// The test passes if corners of borders' contents' have proper corner radiuses
VerifyScreenshot();
}
#endif
}
6 changes: 2 additions & 4 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21202.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if WINDOWS
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -22,5 +21,4 @@ public void Issue21202Test()
VerifyScreenshot();
}
}
}
#endif
}
4 changes: 1 addition & 3 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21314.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#if IOS
using NUnit.Framework;
using NUnit.Framework.Legacy;
using UITest.Appium;
Expand All @@ -22,5 +21,4 @@ public void ImageShouldBePortrait()
ClassicAssert.Greater(image.Height, image.Width);
}
}
}
#endif
}
6 changes: 2 additions & 4 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21394.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if WINDOWS
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -24,5 +23,4 @@ public void Issue21394Test()
VerifyScreenshot();
}
}
}
#endif
}
11 changes: 5 additions & 6 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21437.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if ANDROID
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -17,10 +16,10 @@ public Issue21437(TestDevice device)
[Category(UITestCategories.Gestures)]
public void ExceptionShouldNotBeThrown()
{
_ = App.WaitForElement("Item2");
App.DoubleClick("Item2");
App.WaitForElement("Item2");
App.DoubleTap("Item2");
App.WaitForNoElement("Item2");

//The test passes if no exception is thrown
}
}
#endif
}
6 changes: 2 additions & 4 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21706.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if WINDOWS
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -23,5 +22,4 @@ public async Task ImageButtonStuckAfterRightClick()
VerifyScreenshot();
}
}
}
#endif
}
6 changes: 2 additions & 4 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21787.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if WINDOWS
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -20,5 +19,4 @@ public void LabelTextDecorationsWorks()

VerifyScreenshot();
}
}
#endif
}
4 changes: 1 addition & 3 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22042.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if !MACCATALYST
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand Down Expand Up @@ -29,4 +28,3 @@ public void BorderColorShouldChange()
}
}
}
#endif
4 changes: 1 addition & 3 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22183.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if IOS
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshots. Already available on the latest build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed this snapshot in the latest changes.

using UITest.Core;

Expand Down Expand Up @@ -29,4 +28,3 @@ public void RadioButtonWithValueChangeSelected()
}
}
}
#endif
7 changes: 3 additions & 4 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue2241.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#if IOS
#if IOS || ANDROID //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms iOS and Android.
using NUnit.Framework;
using NUnit.Framework.Legacy;
using UITest.Appium;
Expand All @@ -19,12 +19,11 @@ public Issue2241(TestDevice testDevice) : base(testDevice)
[Category(UITestCategories.Compatibility)]
public void ChangeOrientationCheckScroll()
{
var grid1 = App.FindElement("MainGrid").GetRect();
var grid1 = App.WaitForElement("MainGrid").GetRect();
App.SetOrientationLandscape();
App.ScrollDown("TestScrollView", ScrollStrategy.Programmatically);
App.SetOrientationPortrait();
var grid2 = App.FindElement("MainGrid").GetRect();
App.Screenshot("Did it resize ok? Do you see some white on the bottom?");
var grid2 = App.WaitForElement("MainGrid").GetRect();

ClassicAssert.AreEqual(grid1.CenterY(), grid2.CenterY());
}
Expand Down
4 changes: 1 addition & 3 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22606.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ public Issue22606(TestDevice device) : base(device) { }

public override string Issue => "Border does not expand on Content size changed";

#if !MACCATALYST
[Test]
public void BorderBackgroundExpandsOnContentSizeChanged()
{
Expand All @@ -22,9 +21,8 @@ public void BorderBackgroundExpandsOnContentSizeChanged()
App.Tap("SetHeightTo500");
VerifyScreenshot("Issue22606_SetHeightTo500");
}
#endif

#if ANDROID || IOS
#if ANDROID || IOS //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms iOS and Android.
[Test]
public void BorderBackgroundSizeUpdatesWhenRotatingScreen()
{
Expand Down
8 changes: 3 additions & 5 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22630.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if IOS
using NUnit.Framework;
using NUnit.Framework;
using NUnit.Framework.Legacy;
using UITest.Appium;
using UITest.Core;
Expand All @@ -20,8 +19,7 @@ public void ListViewScrolled()
{
App.WaitForElement("TestListView");
App.ScrollDown("TestListView", ScrollStrategy.Gesture, swipeSpeed: 1000);
var result = App.FindElement("TestLabel").GetText();
var result = App.WaitForElement("TestLabel").GetText();
ClassicAssert.AreEqual("Success", result);
}
}
#endif
}
6 changes: 2 additions & 4 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22750.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if ANDROID
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand Down Expand Up @@ -28,5 +27,4 @@ public void RadioButtonUpdateValueInsideBorder()
VerifyScreenshot("RadioButtonUpdateValueInsideBorderYes");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshot on macOS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images generated for Mac from this CI have not proper, Could we attempt to retrigger the CI for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failing because the test is pending:
image
Attached it.

}
}
#endif
}
6 changes: 2 additions & 4 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22937.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if ANDROID || WINDOWS
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -23,5 +22,4 @@ public void ToolbarItemFontColorDynamicUpdate()
VerifyScreenshot();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshot on Mac.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images generated for Mac from this CI have not proper, Could we attempt to retrigger the CI for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better wait to #27531

}
}
#endif
}
2 changes: 1 addition & 1 deletion src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue4484.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#if ANDROID
#if ANDROID || IOS //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms iOS and Android.
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;
Expand Down
Binary file added ...s/snapshots/ios/BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...ols/tests/TestCases.iOS.Tests/snapshots/ios/ImageButtonStuckAfterRightClick.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/Issue21202Test.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/Issue21394Test.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/LabelTextDecorationsWorks.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...ests/TestCases.iOS.Tests/snapshots/ios/RadioButtonUpdateValueInsideBorderNo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...sts/TestCases.iOS.Tests/snapshots/ios/RadioButtonUpdateValueInsideBorderYes.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...s/tests/TestCases.iOS.Tests/snapshots/ios/ToolbarItemFontColorDynamicUpdate.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading