Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BindingSG] Added Binding.Create support for xaml generated sources #27610

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[BindingSG] Added Binding.Create support for xaml generated sources #27610

wants to merge 2 commits into from
+273 −18

Conversation

jkurdek
Copy link
Member

@jkurdek jkurdek commented Feb 6, 2025

Description of Change

Binding source generator encounters problems when interacting with XamlG. During generation of bindings we dont see the outcome of XamlG, which then results in Roslyn being unable to return correct symbol.

We had a workaround for that for .SetBinding method. This PR brings the same workaround to the Bindings.Create method. It also adds some integration tests for both scenarios

Issues Fixed

Fixes #26616

@jkurdek jkurdek requested a review from a team as a code owner February 6, 2025 13:59
@jkurdek jkurdek self-assigned this Feb 6, 2025
Copilot
Copilot AI reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

src/Controls/src/BindingSourceGen/InvocationParser.cs Outdated Show resolved Hide resolved
@jsuarezruiz jsuarezruiz added the area-xaml XAML, CSS, Triggers, Behaviors label Feb 6, 2025
@jkurdek jkurdek force-pushed the binding-sg/generate-create-binding-for-xamlg-generated-sources branch from 83e2116 to ae7daff Compare February 6, 2025 14:37
simonrozsival
simonrozsival previously approved these changes Feb 7, 2025
View reviewed changes
rmarinho
rmarinho requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it needs rebase

@jkurdek jkurdek force-pushed the binding-sg/generate-create-binding-for-xamlg-generated-sources branch from 567d15e to c5f1d8f Compare February 13, 2025 09:27
@StephaneDelcroix
Copy link
Contributor

we need a way of declaring dependencies for sourcegens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@StephaneDelcroix StephaneDelcroix StephaneDelcroix approved these changes

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@simonrozsival simonrozsival Awaiting requested review from simonrozsival

@rmarinho rmarinho Awaiting requested review from rmarinho

Requested changes must be addressed to merge this pull request.

Assignees

@jkurdek jkurdek

Labels
area-xaml XAML, CSS, Triggers, Behaviors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiled code binding isn't intercepted
5 participants
@jkurdek @StephaneDelcroix @simonrozsival @rmarinho @jsuarezruiz