[Android] Fixed the ScrollbarVisibility issues #27613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
karthikraja-arumugam
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Core/src/Platform/Android/MauiScrollView.cs:72
- [nitpick] The variable name
_verticalScrollVisibilityshould not be prefixed with an underscore as it is not a private field. Consider renaming it toverticalScrollVisibility.
ScrollBarVisibility _verticalScrollVisibility = scrollBarVisibility;
| if (_defaultVerticalScrollVisibility == 0) | ||
| _defaultVerticalScrollVisibility = VerticalScrollBarEnabled ? ScrollBarVisibility.Always : ScrollBarVisibility.Never; | ||
|
|
||
| if (scrollBarVisibility == ScrollBarVisibility.Default) | ||
| scrollBarVisibility = _defaultVerticalScrollVisibility; | ||
|
|
||
| VerticalScrollBarEnabled = scrollBarVisibility == ScrollBarVisibility.Always; | ||
|
|
||
| this.HandleScrollBarVisibilityChange(); | ||
| ScrollbarFadingEnabled = _verticalScrollVisibility != ScrollBarVisibility.Always; |
There was a problem hiding this comment.
The removal of the HandleScrollBarVisibilityChange method and the addition of PlatformInterop.RequestLayoutIfNeeded could potentially be a breaking change. Please ensure this change is documented and communicated appropriately.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
Initial Case:
ScrollBarFadingEnabledproperty is always set to true even whenScrollBarVisibilityis set toAlways. As a result, the scrollbar remains hidden in the Always visibility mode.Dynamic Case:
After fixing the initial issue, it was observed that when the visibility mode changes dynamically from
DefaulttoAlways, the scrollbar does not display correctly. AlthoughScrollBarFadingEnabledis updated properly, the scrollbar remains hidden because the HandleScrollBarVisibilityChange method processes both its true and false states, and RequestLayout is not called.In the native Android itself, dynamic changes to
ScrollbarFadingEnabledare not properly reflected in the UI until the view is scrolled. CallingRequestLayoutwhen dynamic changes occur ensures that the native UI updates correctly.Description of Change
Initial Case:
ScrollBarFadingEnabledbased on ScrollBarVisibility resolves the issue.Dynamic Case:
RequestLayoutIfNeededefficiently resolves the dynamic issues and ensures that the UI updates properly. With RequestLayoutIfNeeded, calling AwakenScrollBars may no longer be necessary.Issues Fixed
Fixes #24894
Fixes #12760
Tested the behaviour in the following platforms
Screenshot
VerticalScrollbarVisibility
VerticalScrollBarIssue.mov
VerticalScrollbarFix.mov
HorizontalScrollbarVisibility
HorizontalScrollbarIssue.mov
HorizontalScrollbarFix.mov