[iOS] Fix for Flyout Menu Backdrop Area does not Readjust on Orientation Change #27700
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @BagavathiPerumal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
karthikraja-arumugam
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
… ViewDidLayoutSubviews() and managing the orientation observer.
…havior is locked.
github-actions
bot
force-pushed
the
fix-21105
branch
from
261bbb3 to
2d50b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
The root cause of the issue is that TapoffView is initialized with the current View.Bounds only at the time of its creation. However, when the device orientation changes, View.Bounds updates dynamically, while TapoffView does not adjust accordingly. As a result, since TapoffView's frame is not updated after its initial creation, it fails to cover the intended area when the screen dimensions change.
Description of Issue Fix
The fix involves overriding ViewDidLayoutSubviews() to dynamically update TapoffView.Frame when IsOpen and its frame differs from View.Bounds. Since ViewDidLayoutSubviews() is called whenever the view's layout is adjusted, including after rotation, this ensures TapoffView resizes correctly. Additionally, the condition prevents unnecessary updates by only modifying the frame when needed.
Tested the behavior in the following platforms.
Issues Fixed
Fixes #21105
Output
BeforeFix-FlyoutBackDrop.mov
AfterFix-FlyoutBackDrop.mov