Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Enabling more UI Tests by removing platform specific condition - 11 #27764

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LogishaSelvarajSF4525
Copy link
Contributor

Description of Change

The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 11th group of tests enabled.

Test Cases:

  • Issue16910
  • Issue17283
  • Issue19338
  • Issue20903
  • Issue21967
  • Issue22417
  • Issue22674
  • Issue968

Fixes #22902

@LogishaSelvarajSF4525 LogishaSelvarajSF4525 added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels Feb 13, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 13, 2025
Copy link
Contributor

Hey there @LogishaSelvarajSF4525! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@LogishaSelvarajSF4525 LogishaSelvarajSF4525 marked this pull request as ready for review February 13, 2025 06:24
@Copilot Copilot bot review requested due to automatic review settings February 13, 2025 06:24
@LogishaSelvarajSF4525 LogishaSelvarajSF4525 requested a review from a team as a code owner February 13, 2025 06:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.

Files not reviewed (3)
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20903.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19338.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16910.cs: Evaluated as low risk

@@ -1,4 +1,5 @@
using NUnit.Framework;
#if TEST_FAILS_ON_WINDOWS //This test is failing, likely due to product issue, for mor information: https://github.com/dotnet/maui/issues/27059
Copy link
Preview

Copilot AI Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment contains a spelling mistake: 'for mor information' should be 'for more information'.

Suggested change
#if TEST_FAILS_ON_WINDOWS //This test is failing, likely due to product issue, for mor information: https://github.com/dotnet/maui/issues/27059
#if TEST_FAILS_ON_WINDOWS //This test is failing, likely due to product issue, for more information: https://github.com/dotnet/maui/issues/27059

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the small typo?

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@@ -1,4 +1,4 @@
#if ANDROID
#if TEST_FAILS_ON_CATALYST //TapCoordinates is not working on Catalyst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed by #27603
After merge it, can re-enable the test on Catalyst.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged the linked PR, can we update it for this one please? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST] Review all (UI) Tests and remove platform-specific runs where possible
3 participants