-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Enabling more UI Tests by removing platform specific condition - 11 #27764
base: main
Are you sure you want to change the base?
[Testing] Enabling more UI Tests by removing platform specific condition - 11 #27764
Conversation
Hey there @LogishaSelvarajSF4525! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.
Files not reviewed (3)
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20903.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19338.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16910.cs: Evaluated as low risk
@@ -1,4 +1,5 @@ | |||
using NUnit.Framework; | |||
#if TEST_FAILS_ON_WINDOWS //This test is failing, likely due to product issue, for mor information: https://github.com/dotnet/maui/issues/27059 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment contains a spelling mistake: 'for mor information' should be 'for more information'.
#if TEST_FAILS_ON_WINDOWS //This test is failing, likely due to product issue, for mor information: https://github.com/dotnet/maui/issues/27059 | |
#if TEST_FAILS_ON_WINDOWS //This test is failing, likely due to product issue, for more information: https://github.com/dotnet/maui/issues/27059 |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the small typo?
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@@ -1,4 +1,4 @@ | |||
#if ANDROID | |||
#if TEST_FAILS_ON_CATALYST //TapCoordinates is not working on Catalyst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed by #27603
After merge it, can re-enable the test on Catalyst.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged the linked PR, can we update it for this one please? :)
Description of Change
The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 11th group of tests enabled.
Test Cases:
Fixes #22902