Merge pull request #8329 from drewnoakes/fix-8305-remove-shared-project-reference

Fix broken removal of shared project references

Author: drewnoakes

src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/Tree/Dependencies/Models/SharedProjectDependencyModel.cs

@@ -9,8 +9,8 @@ namespace Microsoft.VisualStudio.ProjectSystem.Tree.Dependencies.Models
     internal class SharedProjectDependencyModel : DependencyModel
     {
         private static readonly DependencyFlagCache s_flagCache = new(
-            resolved: DependencyTreeFlags.ProjectDependency + DependencyTreeFlags.SharedProjectDependency + DependencyTreeFlags.SupportsBrowse,
-            unresolved: DependencyTreeFlags.ProjectDependency + DependencyTreeFlags.SharedProjectDependency + DependencyTreeFlags.SupportsBrowse,
+            resolved: DependencyTreeFlags.ProjectDependency + DependencyTreeFlags.SharedProjectDependency + DependencyTreeFlags.SupportsBrowse + ProjectTreeFlags.FileSystemEntity,
+            unresolved: DependencyTreeFlags.ProjectDependency + DependencyTreeFlags.SharedProjectDependency + DependencyTreeFlags.SupportsBrowse + ProjectTreeFlags.FileSystemEntity,
             remove: DependencyTreeFlags.SupportsRuleProperties);
 
         private static readonly DependencyIconSet s_iconSet = new(

tests/Microsoft.VisualStudio.ProjectSystem.Managed.UnitTests/ProjectSystem/Tree/Dependencies/Models/SharedProjectDependencyModelTests.cs

@@ -40,7 +40,8 @@ public void SharedResolved()
                 DependencyTreeFlags.SharedProjectDependency +
                 DependencyTreeFlags.SupportsBrowse +
                 DependencyTreeFlags.ResolvedDependencyFlags -
-                DependencyTreeFlags.SupportsRuleProperties,
+                DependencyTreeFlags.SupportsRuleProperties +
+                ProjectTreeFlags.FileSystemEntity,
                 model.Flags);
         }
 
@@ -74,7 +75,8 @@ public void Unresolved()
                 DependencyTreeFlags.SharedProjectDependency +
                 DependencyTreeFlags.SupportsBrowse +
                 DependencyTreeFlags.UnresolvedDependencyFlags -
-                DependencyTreeFlags.SupportsRuleProperties,
+                DependencyTreeFlags.SupportsRuleProperties +
+                ProjectTreeFlags.FileSystemEntity,
                 model.Flags);
         }
 
@@ -109,7 +111,8 @@ public void Implicit()
                 DependencyTreeFlags.SupportsBrowse +
                 DependencyTreeFlags.ResolvedDependencyFlags -
                 DependencyTreeFlags.SupportsRuleProperties -
-                DependencyTreeFlags.SupportsRemove,
+                DependencyTreeFlags.SupportsRemove +
+                ProjectTreeFlags.FileSystemEntity,
                 model.Flags);
         }
     }