17.13 fixes #9636
Merged
17.13 fixes #9636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We see these errors popping up during regular operations such as branch switches. I'd hoped that they would present themselves as cancellations, however we don't see ` BuildCanceledEventArgs` in our logger. These are advertised as real failures. There's nothing the user can do about these, so it's not helpful to tell the user about them. I hope to revisit this in 17.14 to see if there's still a way to provide helpful warnings when actionable errors occur, without any noise from internal and unactionable errors.
zewditu
approved these changes
Jan 22, 2025
16 tasks
drewnoakes
force-pushed
the
17.13-fixes
branch
2 times, most recently
from
94c6195 to
445f062
Compare
|
The pipeline's not building the PR. I can't tell why. Have asked internally, but need to make progress on getting a build ready for the QB. Merging with review but without automated build, in the hope that the pipeline that produces the insertion PR will work correctly. Have run a full build locally and verified tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for 17.13 to take to the QB.
Includes:
Microsoft Reviewers: Open in CodeFlow