Merge branch 'release/dev17.15' => 'main' (#77939)

I detected changes in the release/dev17.15 branch which have not been
merged yet to main. I'm a robot and am configured to help you
automatically keep main up to date, so I've opened this PR.

This PR merges commits made on release/dev17.15 by the following
committers:

* davidwengier
* CyrusNajmabadi
* ToddGrun
* dotnet-policy-service[bot]
* jjonescz
* akhera99

## Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete
this PR by creating a merge commit, *not* a squash or rebase commit.

<img alt="merge button instructions"
src="https://i.imgur.com/GepcNJV.png" width="300" />

If this repo does not allow creating merge commits from the GitHub UI,
use command line instructions.

## Instructions for merging via command line

Run these commands to merge this pull request from the command line.

``` sh
git fetch
git checkout release/dev17.15
git pull --ff-only
git checkout main
git pull --ff-only
git merge --no-ff release/dev17.15

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/roslyn HEAD:merge/release/dev17.15-to-main
```

<details>
<summary>or if you are using SSH</summary>

```
git push git@github.com:dotnet/roslyn HEAD:merge/release/dev17.15-to-main
```

</details>


After PR checks are complete push the branch
```
git push
```

## Instructions for resolving conflicts

:warning: If there are merge conflicts, you will need to resolve them
manually before merging. You can do this [using GitHub][resolve-github]
or using the [command line][resolve-cli].

[resolve-github]:
https://help.github.com/articles/resolving-a-merge-conflict-on-github/
[resolve-cli]:
https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

## Instructions for updating this pull request

Contributors to this repo have permission update this pull request by
pushing to the branch 'merge/release/dev17.15-to-main'. This can be done
to resolve conflicts or make other changes to this pull request before
it is merged.
The provided examples assume that the remote is named 'origin'. If you
have a different remote name, please replace 'origin' with the name of
your remote.

```
git fetch
git checkout -b merge/release/dev17.15-to-main origin/main
git pull https://github.com/dotnet/roslyn merge/release/dev17.15-to-main
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/roslyn HEAD:merge/release/dev17.15-to-main
```

<details>
    <summary>or if you are using SSH</summary>

```
git fetch
git checkout -b merge/release/dev17.15-to-main origin/main
git pull git@github.com:dotnet/roslyn merge/release/dev17.15-to-main
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet/roslyn HEAD:merge/release/dev17.15-to-main
```

</details>

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or
issues.
Also, if this PR was generated incorrectly, help us fix it. See
https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

Author: dotnet-policy-service[bot]

.git-blame-ignore-revs

@@ -15,4 +15,6 @@ f125c2664d3bffb59536f4d3dfee7fa5323c7721
 32e21b64138876a065081ab4bbe15b1fbea12316
 8ab847ca4cbe30baeb0e5d1cbd68ba40385b01ae
 077012c5bc43649fc705698859143226e48686cf
+# Converting to file scoped namespaces on 3/26/2025. 
+98d41b80f6a192230c045a6576e2a283a407980b
 

.github/workflows/main-merge.yml

@@ -2,9 +2,9 @@
 
 name: Inter-branch merge
 on:
-  schedule:
-    # Create a merge every 3 hours (works only for merges from `main`, others would need a `push` trigger).
-    - cron: '0 */3 * * *'
+  # schedule:
+  #   # Create a merge every 3 hours (works only for merges from `main`, others would need a `push` trigger).
+  #   - cron: '0 */3 * * *'
   workflow_dispatch:
     inputs:
       configuration_file_branch:

eng/Versions.props

@@ -5,8 +5,8 @@
     Roslyn version
   -->
   <PropertyGroup>
-    <MajorVersion>4</MajorVersion>
-    <MinorVersion>15</MinorVersion>
+    <MajorVersion>5</MajorVersion>
+    <MinorVersion>0</MinorVersion>
     <PatchVersion>0</PatchVersion>
     <PreReleaseVersionLabel>1</PreReleaseVersionLabel>
     <VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>

eng/config/BannedSymbols.txt

@@ -26,8 +26,6 @@ M:Microsoft.CodeAnalysis.Document.GetOptionsAsync(System.Threading.CancellationT
 T:Microsoft.CodeAnalysis.Options.DocumentOptionSet; Use AnalyzerConfigOptions instead
 M:Microsoft.VisualStudio.Shell.ServiceExtensions.GetService``2(System.IServiceProvider); Use RoslynServiceExtensions instead. This extension internally relies on ThreadHelper, which is incompatible with testing.
 M:Microsoft.VisualStudio.Shell.ServiceExtensions.GetService``2(System.IServiceProvider,System.Boolean); Use RoslynServiceExtensions instead. This extension internally relies on ThreadHelper, which is incompatible with testing
-M:Microsoft.VisualStudio.Shell.ServiceExtensions.GetServiceAsync``2(Microsoft.VisualStudio.Shell.IAsyncServiceProvider); Use RoslynServiceExtensions instead. This extension internally relies on ThreadHelper, which is incompatible with testing
-M:Microsoft.VisualStudio.Shell.ServiceExtensions.GetServiceAsync``2(Microsoft.VisualStudio.Shell.IAsyncServiceProvider,System.Boolean); Use RoslynServiceExtensions instead. This extension internally relies on ThreadHelper, which is incompatible with testing
 P:Microsoft.VisualStudio.Shell.ThreadHelper.JoinableTaskFactory; Use IThreadingContext.JoinableTaskFactory instead.
 M:Microsoft.CodeAnalysis.Formatting.Formatter.FormatAsync(Microsoft.CodeAnalysis.Document,Microsoft.CodeAnalysis.Options.OptionSet,System.Threading.CancellationToken); Use internal overload instead
 M:Microsoft.CodeAnalysis.Formatting.Formatter.FormatAsync(Microsoft.CodeAnalysis.Document,Microsoft.CodeAnalysis.Text.TextSpan,Microsoft.CodeAnalysis.Options.OptionSet,System.Threading.CancellationToken); Use overload with SyntaxFormattingOptions instead

eng/config/PublishData.json

@@ -178,16 +178,6 @@
       "insertionTitlePrefix": "[d17.14 P3]",
       "insertionCreateDraftPR": false
     },
-    "release/dev17.15": {
-      "nugetKind": [
-        "Shipping",
-        "NonShipping"
-      ],
-      "vsBranch": "feature/d18initial",
-      "vsMajorVersion": 17,
-      "insertionTitlePrefix": "[d17.15 P1 initial]",
-      "insertionCreateDraftPR": false
-    },
     "main": {
       "nugetKind": [
         "Shipping",

eng/config/branch-merge.jsonc

@@ -1,9 +1,9 @@
 // Used by .github/workflows/main-merge.yml
 {
     "merge-flow-configurations": {
-        "main": {
-            "MergeToBranch": "release/dev17.15",
-            "ExtraSwitches": "-QuietComments"
-        }
+        // "main": {
+        //     "MergeToBranch": "release/dev17.15",
+        //     "ExtraSwitches": "-QuietComments"
+        // }
     }
 }

src/Analyzers/CSharp/Analyzers/AddRequiredParentheses/CSharpAddRequiredExpressionParenthesesDiagnosticAnalyzer.cs

@@ -13,7 +13,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.AddRequiredParentheses;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpAddRequiredExpressionParenthesesDiagnosticAnalyzer :
+internal sealed class CSharpAddRequiredExpressionParenthesesDiagnosticAnalyzer :
     AbstractAddRequiredParenthesesDiagnosticAnalyzer<
         ExpressionSyntax, ExpressionSyntax, SyntaxKind>
 {

src/Analyzers/CSharp/Analyzers/AddRequiredParentheses/CSharpAddRequiredPatternParenthesesDiagnosticAnalyzer.cs

@@ -13,7 +13,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.AddRequiredParentheses;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpAddRequiredPatternParenthesesDiagnosticAnalyzer :
+internal sealed class CSharpAddRequiredPatternParenthesesDiagnosticAnalyzer :
     AbstractAddRequiredParenthesesDiagnosticAnalyzer<
         PatternSyntax, BinaryPatternSyntax, SyntaxKind>
 {

src/Analyzers/CSharp/Analyzers/ConvertNamespace/ConvertToBlockScopedNamespaceDiagnosticAnalyzer.cs

@@ -12,7 +12,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.ConvertNamespace;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class ConvertToBlockScopedNamespaceDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
+internal sealed class ConvertToBlockScopedNamespaceDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
 {
     public ConvertToBlockScopedNamespaceDiagnosticAnalyzer()
         : base(IDEDiagnosticIds.UseBlockScopedNamespaceDiagnosticId,

src/Analyzers/CSharp/Analyzers/ConvertNamespace/ConvertToFileScopedNamespaceDiagnosticAnalyzer.cs

@@ -12,7 +12,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.ConvertNamespace;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class ConvertToFileScopedNamespaceDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
+internal sealed class ConvertToFileScopedNamespaceDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
 {
     public ConvertToFileScopedNamespaceDiagnosticAnalyzer()
         : base(IDEDiagnosticIds.UseFileScopedNamespaceDiagnosticId,

src/Analyzers/CSharp/Analyzers/FileHeaders/CSharpFileHeaderDiagnosticAnalyzer.cs

@@ -8,7 +8,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.FileHeaders;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpFileHeaderDiagnosticAnalyzer : AbstractFileHeaderDiagnosticAnalyzer
+internal sealed class CSharpFileHeaderDiagnosticAnalyzer : AbstractFileHeaderDiagnosticAnalyzer
 {
     protected override AbstractFileHeaderHelper FileHeaderHelper => CSharpFileHeaderHelper.Instance;
 }

src/Analyzers/CSharp/Analyzers/Formatting/CSharpFormattingAnalyzer.cs

@@ -9,7 +9,7 @@
 namespace Microsoft.CodeAnalysis.CodeStyle;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpFormattingAnalyzer : AbstractFormattingAnalyzer
+internal sealed class CSharpFormattingAnalyzer : AbstractFormattingAnalyzer
 {
     protected override ISyntaxFormatting SyntaxFormatting
         => CSharpSyntaxFormatting.Instance;

src/Analyzers/CSharp/Analyzers/MatchFolderAndNamespace/CSharpMatchFolderAndNamespaceDiagnosticAnalyzer.cs

@@ -20,7 +20,7 @@ namespace Microsoft.CodeAnalysis.CSharp.Analyzers.MatchFolderAndNamespace;
 [Export(typeof(CSharpMatchFolderAndNamespaceDiagnosticAnalyzer)), Shared]
 #endif
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpMatchFolderAndNamespaceDiagnosticAnalyzer
+internal sealed class CSharpMatchFolderAndNamespaceDiagnosticAnalyzer
     : AbstractMatchFolderAndNamespaceDiagnosticAnalyzer<SyntaxKind, BaseNamespaceDeclarationSyntax>
 {
 #if !CODE_STYLE

src/Analyzers/CSharp/Analyzers/OrderModifiers/CSharpOrderModifiersDiagnosticAnalyzer.cs

@@ -13,7 +13,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.OrderModifiers;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpOrderModifiersDiagnosticAnalyzer : AbstractOrderModifiersDiagnosticAnalyzer
+internal sealed class CSharpOrderModifiersDiagnosticAnalyzer : AbstractOrderModifiersDiagnosticAnalyzer
 {
     public CSharpOrderModifiersDiagnosticAnalyzer()
         : base(CSharpSyntaxFacts.Instance,

src/Analyzers/CSharp/Analyzers/OrderModifiers/CSharpOrderModifiersHelper.cs

@@ -8,7 +8,7 @@
 
 namespace Microsoft.CodeAnalysis.CSharp.OrderModifiers;
 
-internal class CSharpOrderModifiersHelper : AbstractOrderModifiersHelpers
+internal sealed class CSharpOrderModifiersHelper : AbstractOrderModifiersHelpers
 {
     public static readonly CSharpOrderModifiersHelper Instance = new();
 

src/Analyzers/CSharp/Analyzers/RemoveUnnecessaryParentheses/CSharpRemoveUnnecessaryExpressionParenthesesDiagnosticAnalyzer.cs

@@ -15,7 +15,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.RemoveUnnecessaryParentheses;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpRemoveUnnecessaryExpressionParenthesesDiagnosticAnalyzer
+internal sealed class CSharpRemoveUnnecessaryExpressionParenthesesDiagnosticAnalyzer
     : AbstractRemoveUnnecessaryParenthesesDiagnosticAnalyzer<SyntaxKind, ParenthesizedExpressionSyntax>
 {
     protected override SyntaxKind GetSyntaxKind()

src/Analyzers/CSharp/Analyzers/RemoveUnnecessaryParentheses/CSharpRemoveUnnecessaryPatternParenthesesDiagnosticAnalyzer.cs

@@ -15,7 +15,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.RemoveUnnecessaryParentheses;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpRemoveUnnecessaryPatternParenthesesDiagnosticAnalyzer
+internal sealed class CSharpRemoveUnnecessaryPatternParenthesesDiagnosticAnalyzer
     : AbstractRemoveUnnecessaryParenthesesDiagnosticAnalyzer<SyntaxKind, ParenthesizedPatternSyntax>
 {
     protected override SyntaxKind GetSyntaxKind()

src/Analyzers/CSharp/Analyzers/RemoveUnreachableCode/CSharpRemoveUnreachableCodeDiagnosticAnalyzer.cs

@@ -14,7 +14,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.RemoveUnreachableCode;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpRemoveUnreachableCodeDiagnosticAnalyzer : AbstractBuiltInUnnecessaryCodeStyleDiagnosticAnalyzer
+internal sealed class CSharpRemoveUnreachableCodeDiagnosticAnalyzer : AbstractBuiltInUnnecessaryCodeStyleDiagnosticAnalyzer
 {
     private const string CS0162 = nameof(CS0162); // Unreachable code detected
 

src/Analyzers/CSharp/Analyzers/RemoveUnusedParametersAndValues/CSharpRemoveUnusedParametersAndValuesDiagnosticAnalyzer.cs

@@ -35,7 +35,7 @@ protected override bool MethodHasHandlesClause(IMethodSymbol method)
     protected override bool IsIfConditionalDirective(SyntaxNode node)
         => node is IfDirectiveTriviaSyntax;
 
-    protected override bool ReturnsThrow(SyntaxNode node)
+    protected override bool ReturnsThrow(SyntaxNode? node)
     {
         if (node is not BaseMethodDeclarationSyntax methodSyntax)
         {

src/Analyzers/CSharp/Analyzers/SimplifyBooleanExpression/CSharpSimplifyConditionalDiagnosticAnalyzer.cs

@@ -13,7 +13,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.SimplifyBooleanExpression;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpSimplifyConditionalDiagnosticAnalyzer :
+internal sealed class CSharpSimplifyConditionalDiagnosticAnalyzer :
     AbstractSimplifyConditionalDiagnosticAnalyzer<
         SyntaxKind,
         ExpressionSyntax,

src/Analyzers/CSharp/Analyzers/SimplifyPropertyPattern/CSharpSimplifyPropertyPatternDiagnosticAnalyzer.cs

@@ -20,7 +20,7 @@ namespace Microsoft.CodeAnalysis.CSharp.SimplifyPropertyPattern;
 ///     <c>x is { a.b: ... }</c>
 /// </summary>
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpSimplifyPropertyPatternDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
+internal sealed class CSharpSimplifyPropertyPatternDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
 {
     public CSharpSimplifyPropertyPatternDiagnosticAnalyzer()
         : base(IDEDiagnosticIds.SimplifyPropertyPatternDiagnosticId,

src/Analyzers/CSharp/Analyzers/UseCoalesceExpression/CSharpUseCoalesceExpressionForNullableTernaryConditionalCheckDiagnosticAnalyzer.cs

@@ -12,7 +12,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.UseCoalesceExpression;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpUseCoalesceExpressionForNullableTernaryConditionalCheckDiagnosticAnalyzer :
+internal sealed class CSharpUseCoalesceExpressionForNullableTernaryConditionalCheckDiagnosticAnalyzer :
     AbstractUseCoalesceExpressionForNullableTernaryConditionalCheckDiagnosticAnalyzer<
         SyntaxKind,
         ExpressionSyntax,

src/Analyzers/CSharp/Analyzers/UseCoalesceExpression/CSharpUseCoalesceExpressionForTernaryConditionalCheckDiagnosticAnalyzer.cs

@@ -12,7 +12,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.UseCoalesceExpression;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpUseCoalesceExpressionForTernaryConditionalCheckDiagnosticAnalyzer :
+internal sealed class CSharpUseCoalesceExpressionForTernaryConditionalCheckDiagnosticAnalyzer :
     AbstractUseCoalesceExpressionForTernaryConditionalCheckDiagnosticAnalyzer<
         SyntaxKind,
         ExpressionSyntax,

src/Analyzers/CSharp/Analyzers/UseConditionalExpression/CSharpUseConditionalExpressionForReturnDiagnosticAnalyzer.cs

@@ -12,7 +12,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.UseConditionalExpression;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpUseConditionalExpressionForReturnDiagnosticAnalyzer
+internal sealed class CSharpUseConditionalExpressionForReturnDiagnosticAnalyzer
     : AbstractUseConditionalExpressionForReturnDiagnosticAnalyzer<IfStatementSyntax>
 {
     public CSharpUseConditionalExpressionForReturnDiagnosticAnalyzer()

src/Analyzers/CSharp/Analyzers/UseDefaultLiteral/CSharpUseDefaultLiteralDiagnosticAnalyzer.cs

@@ -12,7 +12,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.UseDefaultLiteral;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpUseDefaultLiteralDiagnosticAnalyzer : AbstractBuiltInUnnecessaryCodeStyleDiagnosticAnalyzer
+internal sealed class CSharpUseDefaultLiteralDiagnosticAnalyzer : AbstractBuiltInUnnecessaryCodeStyleDiagnosticAnalyzer
 {
     public CSharpUseDefaultLiteralDiagnosticAnalyzer()
         : base(IDEDiagnosticIds.UseDefaultLiteralDiagnosticId,

src/Analyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyForConstructorsHelper.cs

@@ -10,7 +10,7 @@
 
 namespace Microsoft.CodeAnalysis.CSharp.UseExpressionBody;
 
-internal class UseExpressionBodyForConstructorsHelper :
+internal sealed class UseExpressionBodyForConstructorsHelper :
     UseExpressionBodyHelper<ConstructorDeclarationSyntax>
 {
     public static readonly UseExpressionBodyForConstructorsHelper Instance = new();

src/Analyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyForConversionOperatorsHelper.cs

@@ -10,7 +10,7 @@
 
 namespace Microsoft.CodeAnalysis.CSharp.UseExpressionBody;
 
-internal class UseExpressionBodyForConversionOperatorsHelper :
+internal sealed class UseExpressionBodyForConversionOperatorsHelper :
     UseExpressionBodyHelper<ConversionOperatorDeclarationSyntax>
 {
     public static readonly UseExpressionBodyForConversionOperatorsHelper Instance = new();

src/Analyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyForIndexersHelper.cs

@@ -14,7 +14,7 @@
 
 namespace Microsoft.CodeAnalysis.CSharp.UseExpressionBody;
 
-internal class UseExpressionBodyForIndexersHelper :
+internal sealed class UseExpressionBodyForIndexersHelper :
     UseExpressionBodyHelper<IndexerDeclarationSyntax>
 {
     public static readonly UseExpressionBodyForIndexersHelper Instance = new();

src/Analyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyForLocalFunctionHelper.cs

@@ -13,7 +13,7 @@
 
 namespace Microsoft.CodeAnalysis.CSharp.UseExpressionBody;
 
-internal class UseExpressionBodyForLocalFunctionHelper :
+internal sealed class UseExpressionBodyForLocalFunctionHelper :
     UseExpressionBodyHelper<LocalFunctionStatementSyntax>
 {
     public static readonly UseExpressionBodyForLocalFunctionHelper Instance = new();

src/Analyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyForMethodsHelper.cs

@@ -13,7 +13,7 @@
 
 namespace Microsoft.CodeAnalysis.CSharp.UseExpressionBody;
 
-internal class UseExpressionBodyForMethodsHelper :
+internal sealed class UseExpressionBodyForMethodsHelper :
     UseExpressionBodyHelper<MethodDeclarationSyntax>
 {
     public static readonly UseExpressionBodyForMethodsHelper Instance = new();

src/Analyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyForOperatorsHelper.cs

@@ -12,7 +12,7 @@
 
 namespace Microsoft.CodeAnalysis.CSharp.UseExpressionBody;
 
-internal class UseExpressionBodyForOperatorsHelper :
+internal sealed class UseExpressionBodyForOperatorsHelper :
     UseExpressionBodyHelper<OperatorDeclarationSyntax>
 {
     public static readonly UseExpressionBodyForOperatorsHelper Instance = new();

src/Analyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyForPropertiesHelper.cs

@@ -14,7 +14,7 @@
 
 namespace Microsoft.CodeAnalysis.CSharp.UseExpressionBody;
 
-internal class UseExpressionBodyForPropertiesHelper :
+internal sealed class UseExpressionBodyForPropertiesHelper :
     UseExpressionBodyHelper<PropertyDeclarationSyntax>
 {
     public static readonly UseExpressionBodyForPropertiesHelper Instance = new();

src/Analyzers/CSharp/Analyzers/UseImplicitObjectCreation/CSharpUseImplicitObjectCreationDiagnosticAnalyzer.cs

@@ -16,7 +16,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.UseImplicitObjectCreation;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpUseImplicitObjectCreationDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
+internal sealed class CSharpUseImplicitObjectCreationDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
 {
     public CSharpUseImplicitObjectCreationDiagnosticAnalyzer()
         : base(IDEDiagnosticIds.UseImplicitObjectCreationDiagnosticId,

src/Analyzers/CSharp/Analyzers/UseIsNullCheck/CSharpUseIsNullCheckForCastAndEqualityOperatorDiagnosticAnalyzer.cs

@@ -12,7 +12,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.UseIsNullCheck;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpUseIsNullCheckForCastAndEqualityOperatorDiagnosticAnalyzer
+internal sealed class CSharpUseIsNullCheckForCastAndEqualityOperatorDiagnosticAnalyzer
     : AbstractBuiltInCodeStyleDiagnosticAnalyzer
 {
     private static readonly ImmutableDictionary<string, string?> s_properties =

src/Analyzers/CSharp/Analyzers/UseIsNullCheck/CSharpUseIsNullCheckForReferenceEqualsDiagnosticAnalyzer.cs

@@ -11,7 +11,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.UseIsNullCheck;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpUseIsNullCheckForReferenceEqualsDiagnosticAnalyzer : AbstractUseIsNullCheckForReferenceEqualsDiagnosticAnalyzer<SyntaxKind>
+internal sealed class CSharpUseIsNullCheckForReferenceEqualsDiagnosticAnalyzer : AbstractUseIsNullCheckForReferenceEqualsDiagnosticAnalyzer<SyntaxKind>
 {
     public CSharpUseIsNullCheckForReferenceEqualsDiagnosticAnalyzer()
         : base(CSharpAnalyzersResources.Use_is_null_check)

src/Analyzers/CSharp/Analyzers/UseLocalFunction/CSharpUseLocalFunctionDiagnosticAnalyzer.cs

@@ -39,7 +39,7 @@ namespace Microsoft.CodeAnalysis.CSharp.UseLocalFunction;
 ///     }
 /// </summary>
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpUseLocalFunctionDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
+internal sealed class CSharpUseLocalFunctionDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
 {
     public CSharpUseLocalFunctionDiagnosticAnalyzer()
         : base(IDEDiagnosticIds.UseLocalFunctionDiagnosticId,

src/Analyzers/CSharp/Analyzers/UsePatternMatching/CSharpIsAndCastCheckDiagnosticAnalyzer.cs

@@ -29,7 +29,7 @@ namespace Microsoft.CodeAnalysis.CSharp.UsePatternMatching;
 ///     }
 /// </summary>
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpIsAndCastCheckDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
+internal sealed class CSharpIsAndCastCheckDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
 {
     public static readonly CSharpIsAndCastCheckDiagnosticAnalyzer Instance = new();
 

src/Analyzers/CSharp/Analyzers/UseThrowExpression/CSharpUseThrowExpressionDiagnosticAnalyzer.cs

@@ -12,7 +12,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.UseThrowExpression;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpUseThrowExpressionDiagnosticAnalyzer()
+internal sealed class CSharpUseThrowExpressionDiagnosticAnalyzer()
     : AbstractUseThrowExpressionDiagnosticAnalyzer(CSharpCodeStyleOptions.PreferThrowExpression)
 {
     protected override ISemanticFacts SemanticFacts

src/Analyzers/CSharp/Analyzers/UseTupleSwap/CSharpUseTupleSwapDiagnosticAnalyzer.cs

@@ -30,7 +30,7 @@ namespace Microsoft.CodeAnalysis.CSharp.UseTupleSwap;
 /// 
 /// </summary>
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpUseTupleSwapDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
+internal sealed class CSharpUseTupleSwapDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
 {
     public CSharpUseTupleSwapDiagnosticAnalyzer()
         : base(IDEDiagnosticIds.UseTupleSwapDiagnosticId,

src/Analyzers/CSharp/Analyzers/ValidateFormatString/CSharpValidateFormatStringDiagnosticAnalyzer.cs

@@ -12,7 +12,7 @@
 namespace Microsoft.CodeAnalysis.CSharp.ValidateFormatString;
 
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
-internal class CSharpValidateFormatStringDiagnosticAnalyzer :
+internal sealed class CSharpValidateFormatStringDiagnosticAnalyzer :
     AbstractValidateFormatStringDiagnosticAnalyzer<SyntaxKind>
 {
     protected override ISyntaxFacts GetSyntaxFacts()