-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port ToolStripCollectionEditor to the Runtime #12896
base: main
Are you sure you want to change the base?
Port ToolStripCollectionEditor to the Runtime #12896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 16 out of 35 changed files in this pull request and generated no comments.
Files not reviewed (19)
- src/System.Windows.Forms.Design/src/Resources/SR.resx: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.cs.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.de.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.es.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.fr.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.it.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.ja.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.ko.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.pl.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.pt-BR.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.ru.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.tr.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.zh-Hans.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/SR.zh-Hant.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/ToolStripItemEditorForm.cs.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/ToolStripItemEditorForm.de.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/ToolStripItemEditorForm.es.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/ToolStripItemEditorForm.fr.xlf: Language not supported
- src/System.Windows.Forms.Design/src/Resources/xlf/ToolStripItemEditorForm.it.xlf: Language not supported
src/System.Windows.Forms.Design/src/Resources/ToolStripItemEditorForm.resx
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/Resources/System/WinForms/Design/blank.bmp
Outdated
Show resolved
Hide resolved
....Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.ToolStripItemEditorForm.cs
Outdated
Show resolved
Hide resolved
....Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.ToolStripItemEditorForm.cs
Show resolved
Hide resolved
....Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.ToolStripItemEditorForm.cs
Show resolved
Hide resolved
....Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.ToolStripItemEditorForm.cs
Outdated
Show resolved
Hide resolved
....Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.ToolStripItemEditorForm.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.cs
Show resolved
Hide resolved
...System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripCustomTypeDescriptor.cs
Outdated
Show resolved
Hide resolved
....Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.ToolStripItemEditorForm.cs
Outdated
Show resolved
Hide resolved
....Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.ToolStripItemEditorForm.cs
Outdated
Show resolved
Hide resolved
75d4c18
to
8b1915e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12896 +/- ##
===================================================
- Coverage 76.07479% 75.97975% -0.09504%
===================================================
Files 3255 3258 +3
Lines 642151 642970 +819
Branches 47295 47402 +107
===================================================
+ Hits 488515 488527 +12
- Misses 150083 150889 +806
- Partials 3553 3554 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
@LeafShi1 - looks good, could you please test editor behavior in a standalone SystemAware and PerMonitorv2 applications? - Modify the scratch project to contain a toolstrip and a property grid, set selected object in property grid to your ToolStrip, verify if the app is SystemAware or PerMonitorv2 and run it on a scaled monitor. |
|
Fixes #2341
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow