Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ToolStripCollectionEditor to the Runtime #12896

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Feb 7, 2025

Fixes #2341

Proposed changes

  • Port ToolStripCollectionEditor from VSrepo to the Runtime

Customer Impact

  • The ToolStripCollectionEditor can be used in Runtime.

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

image

After

image

Test methodology

  • Manually

Test environment(s)

  • .net 10.0.0-beta.25074.4
Microsoft Reviewers: Open in CodeFlow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 35 changed files in this pull request and generated no comments.

Files not reviewed (19)
  • src/System.Windows.Forms.Design/src/Resources/SR.resx: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.cs.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.de.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.es.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.fr.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.it.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.ja.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.ko.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.pl.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.pt-BR.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.ru.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.tr.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.zh-Hans.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.zh-Hant.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/ToolStripItemEditorForm.cs.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/ToolStripItemEditorForm.de.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/ToolStripItemEditorForm.es.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/ToolStripItemEditorForm.fr.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/ToolStripItemEditorForm.it.xlf: Language not supported
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Feb 7, 2025
@LeafShi1 LeafShi1 marked this pull request as ready for review February 8, 2025 10:11
@LeafShi1 LeafShi1 requested a review from a team as a code owner February 8, 2025 10:11
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Feb 8, 2025
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Feb 11, 2025
@LeafShi1 LeafShi1 force-pushed the Issue_2341_Port_ToolStripCollectionEditor branch from 75d4c18 to 8b1915e Compare February 12, 2025 07:05
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 820 lines in your changes missing coverage. Please review.

Project coverage is 75.97975%. Comparing base (7210b61) to head (8b1915e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12896         +/-   ##
===================================================
- Coverage   76.07479%   75.97975%   -0.09504%     
===================================================
  Files           3255        3258          +3     
  Lines         642151      642970        +819     
  Branches       47295       47402        +107     
===================================================
+ Hits          488515      488527         +12     
- Misses        150083      150889        +806     
- Partials        3553        3554          +1     
Flag Coverage Δ
Debug 75.97975% <0.00000%> (-0.09504%) ⬇️
integration 18.01591% <0.00000%> (-0.05993%) ⬇️
production 49.86123% <0.00000%> (-0.13860%) ⬇️
test 96.96536% <ø> (-0.00001%) ⬇️
unit 47.31736% <0.00000%> (-0.10574%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@LeafShi1 LeafShi1 removed the waiting-author-feedback The team requires more information from the author label Feb 12, 2025
@Tanya-Solyanik
Copy link
Member

@LeafShi1 - looks good, could you please test editor behavior in a standalone SystemAware and PerMonitorv2 applications? - Modify the scratch project to contain a toolstrip and a property grid, set selected object in property grid to your ToolStrip, verify if the app is SystemAware or PerMonitorv2 and run it on a scaled monitor.

@LeafShi1
Copy link
Member Author

@LeafShi1 - looks good, could you please test editor behavior in a standalone SystemAware and PerMonitorv2 applications? - Modify the scratch project to contain a toolstrip and a property grid, set selected object in property grid to your ToolStrip, verify if the app is SystemAware or PerMonitorv2 and run it on a scaled monitor.

The editor form cannot be opened from scratch project
image

The test result in DemoConsole project
AfterChanges

@dotnet-policy-service dotnet-policy-service bot added untriaged The team needs to look at this issue in the next triage and removed 📭 waiting-author-feedback labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged The team needs to look at this issue in the next triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port ToolStripCollectionEditor
2 participants