Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some renames in analyzers source code and tests #12930

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

Tanya-Solyanik
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik commented Feb 12, 2025

Shortened analyzer class name as a follow up on the file rename
Manifest tests are now using a shared test utility to load the input files

Microsoft Reviewers: Open in CodeFlow

Manifest tests are now using a shared test utility to load the input files
@Tanya-Solyanik Tanya-Solyanik requested a review from a team as a code owner February 12, 2025 21:25
@Tanya-Solyanik Tanya-Solyanik requested review from Copilot and KlausLoeffelmann and removed request for a team February 12, 2025 21:25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 19 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • src/System.Windows.Forms.Analyzers.VisualBasic/src/Diagnostic/VisualBasicDiagnosticDescriptors.vb: Language not supported
  • src/System.Windows.Forms.Analyzers.VisualBasic/tests/UnitTests/System.Windows.Forms.Analyzers.VisualBasic.Tests/Analyzers/WFO1001/ImplementITypedDataObjectTests.vb: Language not supported
  • src/System.Windows.Forms.Analyzers.CSharp/src/System/Windows/Forms/CSharp/Analyzers/Diagnostics/CSharpDiagnosticDescriptors.cs: Evaluated as low risk
  • src/System.Windows.Forms.Analyzers.CSharp/tests/UnitTests/Generators/ApplicationConfigurationGenerator/ApplicationConfigurationInitializeBuilderTests.cs: Evaluated as low risk
  • src/System.Windows.Forms.Analyzers/src/System/Windows/Forms/Analyzers/Diagnostics/DiagnosticIDs.cs: Evaluated as low risk
  • src/System.Windows.Forms.Analyzers.CSharp/src/System/Windows/Forms/CSharp/Analyzers/ImplementITypedDataObject/ImplementITypedDataObjectAnalyzer.cs: Evaluated as low risk
@Tanya-Solyanik
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Tanya-Solyanik Tanya-Solyanik merged commit e173bae into dotnet:main Feb 13, 2025
8 checks passed
@Tanya-Solyanik Tanya-Solyanik deleted the flatten-analizer-tests branch February 13, 2025 00:52
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview2 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants