Fixbug: can not search app when sort direction is null

agile.zhou · agile.zhou · commit 98b0867b1dbd · 2024-12-01T22:23:04.000+08:00
diff --git a/src/AgileConfig.Server.Service/AppService.cs b/src/AgileConfig.Server.Service/AppService.cs
@@ -159,7 +159,7 @@ public Task<List<App>> GetAllAppsAsync()
             }
 
             var apps = await _appRepository.QueryPageAsync(exp, current, pageSize, sortField,
-                ascOrDesc.StartsWith("asc") ? "ASC" : "DESC");
+                ascOrDesc?.StartsWith("asc") ?? true ? "ASC" : "DESC");
             var count = await _appRepository.CountAsync(exp);
 
             return (apps, count);
@@ -230,7 +230,7 @@ public Task<List<App>> GetAllAppsAsync()
 
             if (sortProperty.TryGetValue(sortField, out var propertyInfo))
             {
-                appGroupList = ascOrDesc.StartsWith("asc")
+                appGroupList = ascOrDesc?.StartsWith("asc") ?? true
                     ? appGroupList.OrderBy(x => propertyInfo.GetValue(x.App, null)).ToList()
                     : appGroupList.OrderByDescending(x => propertyInfo.GetValue(x.App, null)).ToList();
             }

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ public Task<List<App>> GetAllAppsAsync()`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`var apps = await _appRepository.QueryPageAsync(exp, current, pageSize, sortField,`
`162`		`- ascOrDesc.StartsWith("asc") ? "ASC" : "DESC");`
	`162`	`+ ascOrDesc?.StartsWith("asc") ?? true ? "ASC" : "DESC");`
`163`	`163`	`var count = await _appRepository.CountAsync(exp);`
`164`	`164`
`165`	`165`	`return (apps, count);`
`@@ -230,7 +230,7 @@ public Task<List<App>> GetAllAppsAsync()`
`230`	`230`
`231`	`231`	`if (sortProperty.TryGetValue(sortField, out var propertyInfo))`
`232`	`232`	`{`
`233`		`- appGroupList = ascOrDesc.StartsWith("asc")`
	`233`	`+ appGroupList = ascOrDesc?.StartsWith("asc") ?? true`
`234`	`234`	`? appGroupList.OrderBy(x => propertyInfo.GetValue(x.App, null)).ToList()`
`235`	`235`	`: appGroupList.OrderByDescending(x => propertyInfo.GetValue(x.App, null)).ToList();`
`236`	`236`	`}`