MySQL sharding storage #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable sharding by mysql partitions Closes: #172
|
|
|
@laskoviymishka has imported your pull request. If you are a member of Transfer team, you can view this diff. |
boooec
suggested changes
Feb 20, 2025
Comment on lines
+121
to
+125
| if IsPartition(table.Filter) { | ||
| resultQuery += string(table.Filter) | ||
| } else { | ||
| resultQuery += " WHERE " + string(table.Filter) | ||
| } |
There was a problem hiding this comment.
Since we have many developers and some of them not very familiar with MySQL, I'd rather added comments here, with link to MySQL doc or some of query examples answering question "Why in first if-case is no WHERE keyword?"
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
robot-piglet
pushed a commit
that referenced
this pull request
Feb 21, 2025
Enable sharding by mysql partitions Closes: #172 --- Pull Request resolved: #205 Co-authored-by: tserakhau <tserakhau@double.cloud> Co-authored-by: tserakhau <tserakhau@double.cloud> Co-authored-by: tserakhau <tserakhau@double.cloud> Co-authored-by: tserakhau <tserakhau@double.cloud> Co-authored-by: tserakhau <tserakhau@double.cloud> Co-authored-by: tserakhau <tserakhau@double.cloud> Co-authored-by: tserakhau <tserakhau@double.cloud> commit_hash:9d122f2ca92d2b24309bbcb15015aacd8f828b25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable sharding by mysql partitions
Closes: #172