Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: module cleanup #823

Merged

Conversation

ublefo
Copy link
Contributor

@ublefo ublefo commented Mar 28, 2024

I have identified some unused components in the source tree that was not referenced anywhere else, let's clean them up now. I've checked whether the modules are in use or not with the following steps. When both of them return no matches, I will deem a component unused.

  1. Searching for references to the service name such as tutorGroupManager .
  2. Searching for references to the component name such as tutor-group-manager to check if the component is being used by anything else other than the import lists.

Tested in Chrome and everything seems to work, unit tests are all broken so I'm unable to run them.

The following components are currently unused but not removed, those should be migrated so we can put them back into the UI.

  • achievement-box-plot
  • summary-task-status-scatter
  • target-grade-pie-chart
  • task-completion-box-plot

@jakerenzella jakerenzella merged commit 38cef6a into doubtfire-lms:development Apr 30, 2024
1 check failed
@ublefo ublefo deleted the refactor/module-cleanup branch May 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants