feat: updates the task ID calculation logic in the Download #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes a version bump for the
dragonfly-apipackage and updates to the logic for calculating task IDs in theDownloadstruct across multiple files. The changes ensure thatpiece_lengthis now included as a factor in task ID calculation.Version update:
Cargo.toml: Updated thedragonfly-apipackage version from2.1.37to2.1.38.Task ID calculation updates:
pkg/apis/common/v2/common.pb.go: Updated the comment for theContentForCalculatingTaskIdfield in theDownloadstruct to includepiece_lengthas a factor in task ID calculation.pkg/apis/common/v2/common.proto: Modified the documentation for thecontent_for_calculating_task_idfield in theDownloadmessage to reflect the inclusion ofpiece_length.proto/common.proto: Updated the comment for thecontent_for_calculating_task_idfield in theDownloadmessage to includepiece_length.src/common.v2.rs: Adjusted the comment for thecontent_for_calculating_task_idfield in theDownloadstruct to account forpiece_lengthin task ID calculation.Related Issue
Motivation and Context