Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][broker] PIP-264: Add managed ledger cache metrics #33

Closed

Conversation

dragosvictor
Copy link
Owner

@dragosvictor dragosvictor commented Jun 11, 2024

PIP-264

Motivation

Adds Managed Ledger cache metrics to the OpenTelemetry pipeline.

Modifications

  • Adds the metrics described in [feat][doc] PIP-264: Add OpenTelemetry ML cache metrics reference apache/pulsar-site#913 to the collector runs.
  • Pass OpenTelemetry instance to the ManagedClientFactoryImpl constructor, to be used by all ML OTel metrics.
  • Factor out functionality currently located in ManagedLedgerCacheMetrics to PooledByteBufAllocatorStats.java, for reuse in the the OTel stats collection.
  • Add field Rate.totalValueAdder keeping track of cumulative values added to the Rate, further simplifying the design.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added metric test in OpenTelemetryManagedLedgerCacheStatsTest

Does this pull request potentially affect one of the following parts:

Documentation

Matching PR in forked repository

PR in forked repository: #33

@dragosvictor dragosvictor deleted the dmisca-pip-264-managed-ledger-cache-metrics branch June 26, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant