Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][broker] PIP-264: Add replication subscription stats #40

Closed

Conversation

dragosvictor
Copy link
Owner

@dragosvictor dragosvictor commented Jul 11, 2024

PIP-264

Motivation

Adds replicated subscription metrics, defined here and here, to the OpenTelemetry pipeline.

Modifications

  • Added metrics, as described by [feat][doc] PIP-264: Add replication subscription metrics reference apache/pulsar-site#941, to the OpenTelemetry pipeline. Since these metrics expose no high-cardinality attributes, they can be stored as synchronous OpenTelemetry instruments.
  • Instead of the existing Prometheus pulsar_replicated_subscriptions_pending_snapshots counter, opted to expose the number of snapshot operations attempted. The snapshot duration histogram maintains the number of operations completed. Using these values, the number of pending snapshots can be computed at any time.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Updated test ReplicatedSubscriptionTest#testReplicatedSubscriptionAcrossTwoRegions to cover the new metric values.

Does this pull request potentially affect one of the following parts:

Documentation

Matching PR in forked repository

PR in forked repository: #40

@dragosvictor dragosvictor deleted the dmisca-pip-264-replication-subscription-stats branch August 30, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant