[feat][broker] PIP-264: Add replication subscription stats #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP-264
Motivation
Adds replicated subscription metrics, defined here and here, to the OpenTelemetry pipeline.
Modifications
pulsar_replicated_subscriptions_pending_snapshots
counter, opted to expose the number of snapshot operations attempted. The snapshot duration histogram maintains the number of operations completed. Using these values, the number of pending snapshots can be computed at any time.Verifying this change
This change added tests and can be verified as follows:
ReplicatedSubscriptionTest#testReplicatedSubscriptionAcrossTwoRegions
to cover the new metric values.Does this pull request potentially affect one of the following parts:
Documentation
doc
doc-required
[feat][doc] PIP-264: Add replication subscription metrics reference apache/pulsar-site#941doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: #40