Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust height when select all #4639

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix: adjust height when select all #4639

merged 1 commit into from
Feb 14, 2025

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Feb 13, 2025

close https://github.com/dream-num/univer-pro/issues/3996

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 13, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Feb 13, 2025
Copy link

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 34 seconds
commit  a4f1012
info  For more information, see full report

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.67%. Comparing base (15a943c) to head (a4f1012).
Report is 19 commits behind head on dev.

Files with missing lines Patch % Lines
...mands/commands/set-worksheet-row-height.command.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4639      +/-   ##
==========================================
- Coverage   32.69%   32.67%   -0.03%     
==========================================
  Files        2603     2603              
  Lines      135436   135461      +25     
  Branches    30173    30118      -55     
==========================================
- Hits        44277    44256      -21     
- Misses      91159    91205      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Feb 14, 2025
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Feb 14, 2025
@jikkai jikkai merged commit c274fc8 into dev Feb 14, 2025
10 checks passed
@jikkai jikkai deleted the fix/row-height-allrange branch February 14, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants