changes to support lua DroneCAN messaging #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows for the creation of new HandlerList handlers at runtime
we need to remove the child classes (Subscriber and Client) from the HandlerList linked list before we remove them from their own static linked list, otherwise we temporarily have an object where the handle_message function points at a pure virtual, which if we call it will result in a crash
allows for correct mutex ordering in lua scripting
and allow child class access to the HandlerList mutex
tridge
force-pushed
the
pr-canard-list-sem
branch
from
414753b to
1715920
Compare
|
Can we move the ordering and semaphore fixes out to their own PR? They grew a little more complicated than initially imagined. I'm also not sure if they're responsible for CI failing. They are also more worth backporting in ardupilot. |
|
I found some other issues with the constructor ordering, fixed them, and broke it out into #76 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes 3 changes to support handling DroneCAN messages in lua scripting in ArduPilot