CI fix: pre-exclude source files when analyzing coverage #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcov 2.x, unlike lcov 1.x, gives errors like `geninfo: ERROR: mismatched end line for _ZN12CRC_CRC_Test8TestBodyEv at /home/runner/work/libcanard/libcanard/tests/test_crc.cpp:42: 42 -> 55` for source files which contain gtest tests. These files are removed from the coverage information in a later step, but lcov now fails to create the initial coverage info because of them. Fix this problem (and thus CI) by excluding the files from the initial coverage info instead of removing them later. Note that the exclude order is relevant to ensure all excludes trigger, avoiding errors that some are unused. Verified that identical coverage stats are generated for 2.x as compared to 1.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lcov 2.x, unlike lcov 1.x, gives errors like
geninfo: ERROR: mismatched end line for _ZN12CRC_CRC_Test8TestBodyEv at /home/runner/work/libcanard/libcanard/tests/test_crc.cpp:42: 42 -> 55for source files which contain gtest tests.These files are removed from the coverage information in a later step, but lcov now fails to create the initial coverage info because of them.
Fix this problem (and thus CI) by excluding the files from the initial coverage info instead of removing them later. Note that the exclude order is relevant to ensure all excludes trigger, avoiding errors that some are unused. Verified that identical coverage stats are generated for 2.x as compared to 1.x.