Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial hash sources #54

Open
heddn opened this issue Jan 23, 2017 · 1 comment
Open

Initial hash sources #54

heddn opened this issue Jan 23, 2017 · 1 comment

Comments

@heddn
Copy link

heddn commented Jan 23, 2017

Feature request here. Allow to source the "initial" from a different location than the 'source' key.

In #44, the functionality for "initial" was added. However, it assumes that you have a forked Drupal version and all "initial" files are sourced from the same repo as the "source" key. It might make sense for Pantheon to have all the extra overhead of hosting their own clone of d8, but for my uses, I just want to provide a default settings.local.php that I have sourced inside the local code base. I was hoping I could just use:

      "initial": {
        "../seed/services.local.yml": "sites/default/services.local.yml",
        "../seed/settings.local.php": "sites/default/settings.local.php"
      }

But that doesn't work because it tries to download those files from http://cgit.drupalcode.org/drupal/plain/. Which obviously is going to fail.

@greg-1-anderson
Copy link
Collaborator

The items inside of initial are only really intended for items that should be downloaded from some remote location. Currently, this is only from the repo identified by the source key, but it does seem valuable to have the ability to take things from multiple different sources.

However, for files that exist in your local repository, I would recommend that you follow the pattern used in the ScriptHandler.php handler in drupal-composer/drupal-project. I don't think that drupal-scaffold should take responsibility for the local-file use-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants