Issue #15 #19: Remove transitions and ensure that fieldset type is de…

…fined before comparing
drupalux · Jan 8, 2019 · ccd24d2 · ccd24d2
1 parent effd4e7
commit ccd24d2
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 4 deletions.
diff --git a/claro.theme b/claro.theme
@@ -274,7 +274,7 @@ function claro_preprocess_fieldset(&$variables) {
   $element = $variables['element'];
   $composite_types = ['checkboxes', 'radios'];
 
-  if (in_array($element['#type'], $composite_types) && !empty($variables['element']['#children_errors'])) {
+  if (!empty($element['#type']) && in_array($element['#type'], $composite_types) && !empty($variables['element']['#children_errors'])) {
     $variables['legend_span']['attributes']->addClass('has-error');
   }
 

diff --git a/css/src/components/form--checkbox-radio--ie.css b/css/src/components/form--checkbox-radio--ie.css
@@ -4,7 +4,6 @@
  */
 
 .form-boolean::-ms-check {
-  transition: all var(--speed-transition) ease-in-out 0s, background-image 0s linear 0s;
   border: 1px solid var(--color-input-border);
   display: inline-block;
   width: 18px;

diff --git a/css/src/components/form--checkbox-radio.css b/css/src/components/form--checkbox-radio.css
@@ -59,7 +59,6 @@
  * Input appearance.
  */
 .form-boolean {
-  transition: all var(--speed-transition) ease-in-out 0s, background-image 0s linear 0s;
   appearance: none;
   border: 1px solid var(--color-input-border);
   display: inline-block;

diff --git a/css/src/components/form--text.css b/css/src/components/form--text.css
@@ -14,7 +14,6 @@
   font-size: 1em;
   line-height: 1.5;
   color: var(--color-input-fg);
-  transition: border linear var(--speed-transition), box-shadow linear var(--speed-transition);
   min-height: 3em; /* iOS. */
 }