Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove addresses from issue title #37

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

c-herrewijn
Copy link
Member

@c-herrewijn c-herrewijn commented Feb 19, 2025

This PR contains a fix for: https://github.com/duckdblabs/duckdb-internal/issues/4206

The workflows in duckdb-fuzzer-ci run script run_fuzzer.py from repo duckdb/duckdb-sqlsmith
In case of bugs found by the fuzzer run_fuzzer.py files an issue, but only if the the error message is unique (to prevent duplicates).
The problem is that the error messages contain pointer addresses and therefore are considered unique.
This leads to the duplicate issues: https://github.com/duckdblabs/duckdb-internal/issues/4206

This PR cleans hex-addresses from the error messages, and therefore prevents duplicates.

original error (e.g. duckdb/duckdb-fuzzer#3990)

ABORT THROWN BY INTERNAL EXCEPTION: Assertion triggered in file "/home/runner/work/duckdb-fuzzer-ci/duckdb-fuzzer-ci/src/common/types/hugeint.cpp" on line 129: lhs.upper >= 0 ../duckdb(+0x18efd814) [0x55e53f87e814] ../duckdb(+0x18dd1d3d)

error after sanitzing:

ABORT THROWN BY INTERNAL EXCEPTION: Assertion triggered in file "/home/runner/work/duckdb-fuzzer-ci/duckdb-fuzzer-ci/src/common/types/hugeint.cpp" on line 129: lhs.upper >= 0 ../duckdb(+) [] ../duckdb(+) 

@c-herrewijn
Copy link
Member Author

@carlopi can you review this 1 line code change to fix the issue you registered? (https://github.com/duckdblabs/duckdb-internal/issues/4206)
CI fails on this PR, but seems unrelated to my change.

@carlopi
Copy link
Contributor

carlopi commented Feb 19, 2025

Sure, but I am not sure what's happening here.
Could you explain what are you trying to achieve?

@carlopi
Copy link
Contributor

carlopi commented Feb 19, 2025

Also, the fact that this is failing is not on you, but I would report this somewhere.

@c-herrewijn
Copy link
Member Author

Sure, but I am not sure what's happening here. Could you explain what are you trying to achieve?

@carlopi I updated the PR description with some more context.

@carlopi
Copy link
Contributor

carlopi commented Feb 19, 2025

Thanks, re.sub was surprising to me, but all seems to be working.

@carlopi
Copy link
Contributor

carlopi commented Feb 19, 2025

Actually, I am not really sure what's happening, probably it's fine, and not super relevant either way.

@c-herrewijn
Copy link
Member Author

@Tmonster Tom, I understand you are the owner of the repo, can you check if this can be merged?

@c-herrewijn
Copy link
Member Author

Note: I created a separate PR to fix CI (hopefully): #38

Copy link
Collaborator

@Tmonster Tmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Tmonster Tmonster merged commit e1eb0ae into duckdb:main Feb 20, 2025
25 checks passed
@c-herrewijn c-herrewijn deleted the remove_addresses_from_issue_title branch March 4, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants