-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove addresses from issue title #37
remove addresses from issue title #37
Conversation
@carlopi can you review this 1 line code change to fix the issue you registered? (https://github.com/duckdblabs/duckdb-internal/issues/4206) |
Sure, but I am not sure what's happening here. |
Also, the fact that this is failing is not on you, but I would report this somewhere. |
@carlopi I updated the PR description with some more context. |
Thanks, |
Actually, I am not really sure what's happening, probably it's fine, and not super relevant either way. |
@Tmonster Tom, I understand you are the owner of the repo, can you check if this can be merged? |
Note: I created a separate PR to fix CI (hopefully): #38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR contains a fix for: https://github.com/duckdblabs/duckdb-internal/issues/4206
The workflows in
duckdb-fuzzer-ci
run scriptrun_fuzzer.py
from repoduckdb/duckdb-sqlsmith
In case of bugs found by the fuzzer
run_fuzzer.py
files an issue, but only if the the error message is unique (to prevent duplicates).The problem is that the error messages contain pointer addresses and therefore are considered unique.
This leads to the duplicate issues: https://github.com/duckdblabs/duckdb-internal/issues/4206
This PR cleans hex-addresses from the error messages, and therefore prevents duplicates.
original error (e.g. duckdb/duckdb-fuzzer#3990)
error after sanitzing: