From 80e31afdd93c67a055ad72032c8608d639853318 Mon Sep 17 00:00:00 2001 From: Christiaan Herrewijn Date: Thu, 6 Mar 2025 16:01:03 +0100 Subject: [PATCH 1/2] add EXPORT_DYNAMIC_SYMBOLS for better stack strace --- .github/workflows/build_fuzzer.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build_fuzzer.yml b/.github/workflows/build_fuzzer.yml index 0b80544..5f1cdcc 100644 --- a/.github/workflows/build_fuzzer.yml +++ b/.github/workflows/build_fuzzer.yml @@ -2,7 +2,7 @@ name: Build Fuzzer on: workflow_call: inputs: - git_url: + git_url: required: true type: string git_tag: @@ -18,7 +18,7 @@ on: jobs: build-duckdb: - name: Build + name: Build runs-on: ubuntu-latest timeout-minutes: ${{ inputs.timeout-minutes }} outputs: @@ -31,6 +31,7 @@ jobs: BUILD_PARQUET: 1 BUILD_JEMALLOC: 1 CRASH_ON_ASSERT: 1 + EXPORT_DYNAMIC_SYMBOLS: 1 GEN: ninja steps: @@ -45,14 +46,14 @@ jobs: - name: Setup Ccache uses: hendrikmuhs/ccache-action@main - + - id: find-hash run: echo "hash=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT - + - name: create build sqlsmith extension file shell: bash run: | - echo "duckdb_extension_load(sqlsmith + echo "duckdb_extension_load(sqlsmith GIT_URL https://github.com/${{ inputs.git_url }} GIT_TAG ${{ inputs.git_tag }} )" > sqlsmith.cmake @@ -65,4 +66,4 @@ jobs: - uses: actions/upload-artifact@v4 with: name: duckdb - path: build/debug/duckdb \ No newline at end of file + path: build/debug/duckdb From cdd6971e49e87d054653aeec151af98295788bad Mon Sep 17 00:00:00 2001 From: Christiaan Herrewijn Date: Thu, 6 Mar 2025 16:02:35 +0100 Subject: [PATCH 2/2] fix propagation of duckdb has between jobs --- .github/workflows/cifuzz-basic.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cifuzz-basic.yml b/.github/workflows/cifuzz-basic.yml index 96ee29a..a8caccd 100644 --- a/.github/workflows/cifuzz-basic.yml +++ b/.github/workflows/cifuzz-basic.yml @@ -39,4 +39,4 @@ jobs: enable_verification: false repo: ${{ github.repository }} secrets: - DUCKDB_HASH: ${{ needs.build-duckdb.outputs.duckdb-hash }} \ No newline at end of file + DUCKDB_HASH: ${{ needs.build-duckdb.outputs.hash }}