From 9554721fd5eca0eb7f4dbbbc37f854dce652b429 Mon Sep 17 00:00:00 2001 From: Benjamin Smith Date: Fri, 10 May 2024 19:40:49 +0200 Subject: [PATCH] move the warning log to get_results --- dune_client/api/execution.py | 12 ++++++++---- dune_client/api/extensions.py | 4 ---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dune_client/api/execution.py b/dune_client/api/execution.py index a8cb3bb..3d94e63 100644 --- a/dune_client/api/execution.py +++ b/dune_client/api/execution.py @@ -22,6 +22,7 @@ ResultsResponse, ExecutionResultCSV, DuneError, + ExecutionState, ) from dune_client.query import QueryBase @@ -128,9 +129,7 @@ def get_execution_results_csv( return self._get_execution_results_csv_by_url(url=url, params=params) def _get_execution_results_by_url( - self, - url: str, - params: Optional[Dict[str, Any]] = None, + self, url: str, params: Optional[Dict[str, Any]] = None, job_id=None ) -> ResultsResponse: """ GET results from Dune API with a given URL. This is particularly useful for pagination. @@ -139,7 +138,12 @@ def _get_execution_results_by_url( response_json = self._get(url=url, params=params) try: - return ResultsResponse.from_dict(response_json) + result = ResultsResponse.from_dict(response_json) + if result.state == ExecutionState.PARTIAL: + self.logger.warning( + f"execution {job_id} resulted in a partial result set (i.e. results too large)." + ) + return result except KeyError as err: raise DuneError(response_json, "ResultsResponse", err) from err diff --git a/dune_client/api/extensions.py b/dune_client/api/extensions.py index 465be10..ed3d1ff 100644 --- a/dune_client/api/extensions.py +++ b/dune_client/api/extensions.py @@ -420,10 +420,6 @@ def _refresh( if status.state == ExecutionState.FAILED: self.logger.error(status) raise QueryFailed(f"Error data: {status.error}") - if status.state == ExecutionState.PARTIAL: - self.logger.warning( - f"execution {job_id} resulted in a partial result set (i.e. results too large)." - ) return job_id def _fetch_entire_result(