adjust for python 3.12

duneanalytics · Apr 21, 2024 · fe4cc78 · fe4cc78
1 parent 604d505
commit fe4cc78
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml
@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.8", "3.11"]
+        python-version: ["3.8", "3.12"]
     steps:
       - uses: actions/checkout@v3
       - name: Set up Python ${{ matrix.python-version }}

diff --git a/dune_client/util.py b/dune_client/util.py
@@ -3,8 +3,6 @@
 from datetime import datetime, timezone
 from typing import Optional
 
-import pkg_resources
-
 DUNE_DATE_FORMAT = "%Y-%m-%d %H:%M:%S"
 
 
@@ -18,7 +16,13 @@ def get_package_version(package_name: str) -> Optional[str]:
     Returns the package version by `package_name`
     """
     try:
+        # pylint: disable=import-outside-toplevel
+        import pkg_resources
+
         return pkg_resources.get_distribution(package_name).version
+    except ModuleNotFoundError:
+        # Python 3.12 does not have pkg_resources!
+        return None
     except pkg_resources.DistributionNotFound:
         return None