Skip to content

Commit c2276d4

Browse files
authored
Check for nil params to avoid a panic (#10)
1 parent 05d3e0b commit c2276d4

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

params.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ var ErrInvalidParameterFormat = errors.New("invalid parameter format")
1919
// ErrInvalidParameterValue is returned when a parameter key is invalid.
2020
var ErrInvalidParameterValue = errors.New("invalid parameter value")
2121

22+
// ErrMissingParameters is returned when the Params structure is missing from the element.
23+
var ErrMissingParameters = errors.New("missing parameters")
24+
2225
// NewParams creates a new ordered map.
2326
func NewParams() *Params {
2427
p := Params{}
@@ -74,6 +77,9 @@ func (p *Params) Names() []string {
7477
// marshalSFV serializes as defined in
7578
// https://httpwg.org/specs/rfc8941.html#ser-params.
7679
func (p *Params) marshalSFV(b *strings.Builder) error {
80+
if p == nil {
81+
return ErrMissingParameters
82+
}
7783
for _, k := range p.names {
7884
if err := b.WriteByte(';'); err != nil {
7985
return err

0 commit comments

Comments
 (0)