tools/dustElfToBin: Bug fix related to Windows file path and process operation #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the python script (tools/dustElfToBin/dustElfToBin.py) failed on Windows due to three reasons.
File path encoding
Original code use a hard-coded location when an environment variable (
IAR_ARM_BASE
) is not found.However, this treatment should be avoided because the IAR location is much varied depending on version, user's configuration, etc.
Therefore I fixed this code to just raising exception when
IAR_ARM_BASE
is not found.UAC
On Windows 7 or later, sometimes executing ielftool.exe is failed due to privilege issue (Popen returned
WindowsError: [Error 5] Access is denied
).To avoid this error,
shell
should be set toTrue
.ielftool.exe error
Although ielftool.exe returns error, the script continued running.
To handle error case, I changed the script to be terminated when ielftool returns non-zero status.