Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/dustElfToBin: Bug fix related to Windows file path and process operation #3

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tmineno
Copy link

@tmineno tmineno commented Sep 19, 2018

I found the python script (tools/dustElfToBin/dustElfToBin.py) failed on Windows due to three reasons.

  1. File path encoding
    Original code use a hard-coded location when an environment variable (IAR_ARM_BASE) is not found.
    However, this treatment should be avoided because the IAR location is much varied depending on version, user's configuration, etc.
    Therefore I fixed this code to just raising exception when IAR_ARM_BASE is not found.

  2. UAC
    On Windows 7 or later, sometimes executing ielftool.exe is failed due to privilege issue (Popen returned WindowsError: [Error 5] Access is denied).
    To avoid this error, shell should be set to True.

  3. ielftool.exe error
    Although ielftool.exe returns error, the script continued running.
    To handle error case, I changed the script to be terminated when ielftool returns non-zero status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant