Added DroidKlipp #666
Added DroidKlipp #666
Conversation
added DroidKlipp
droidklipp
install update
updated readme to add DroidKlipp
droidklipp
droidklipp
fixed folder creation
fixed folder creating and bug
forgot to add imports
There was a problem hiding this comment.
Hi, thanks for the contribution. There are several things i have to comment on.
You committed a few files that are not necessary, please remove those.
Also, there were some imports made, that seem useless as there are no other changes in the respecting files.
Most importantly:
I do not accept contributions for installers anymore which place themself in the main install menu. That does not mean that i don't accept contributions for installers at all. The way they must be implemented just changed and are called "Community Extensions" now. It's basically kind of a "plugin system" for KIAUH. Have a look at the already existing extensions and how they are implemented: https://github.com/dw-0/kiauh/tree/master/kiauh/extensions
I can recommend having a look at mobileraker, octoapp or klipper_backup for example.
If there are any questions, feel free to ask and i try to help.
Is the code ai generated or is there a particular reason you decided to not use a lot of KIAUH utility functions and helpers for handling inputs or dependency installations and so on?
There was a problem hiding this comment.
Those changes are incorrect, please revert
I should have created a pull equest when I did this but I didn't know how or what a pull request was at the time. I am new and still learning how to use github.
Idk if the making this pull request would remove any updates you guys made already.
Please consider adding DroidKlipp The Android Klipper Screen!