Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type casting fixes, redundant return removed #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

type casting fixes, redundant return removed #16

wants to merge 1 commit into from

Conversation

dlancer
Copy link

@dlancer dlancer commented Oct 28, 2018

No description provided.

@dxxb
Copy link
Owner

dxxb commented Oct 29, 2018

Were these changes prompted by compiler warnings? If so could you please publish the compiler output plus the compiler version and platform (and any compiler switcher required to reproduce it)? Thank you.

@dlancer
Copy link
Author

dlancer commented Oct 30, 2018

Well, with current settings there is no warnings, but you can see it with -Wconversion.
I use Clion, so some of the warnings it is clang-tidy related.
My main platform is Linux amd64. I think on amd64 all will be good without type casting, so we can ignore this.

@dxxb
Copy link
Owner

dxxb commented Oct 30, 2018

I see the warnings with -Wconversion, thank you. I also see quite a few -Wconversion warnings in simavr do you plan to submit fixes for those to upstream simavr too?

@dlancer
Copy link
Author

dlancer commented Oct 30, 2018

I also see quite a few -Wconversion warnings in simavr do you plan to submit fixes for those to upstream simavr too?

I'm do not have free time at the moment, so if you decide submit to upstream that would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants