-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new tracks to the Rekordbox 6 database #121
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 87.92% 87.47% -0.46%
==========================================
Files 17 17
Lines 2998 3017 +19
==========================================
+ Hits 2636 2639 +3
- Misses 362 378 +16 ☔ View full report in Codecov by Sentry. |
Hey @cvdub , sorry for the late response, had a lot of stuff going on. Thank you a lot for your effort, this looks really good! There are a few things i have noticed in your PR that should be resolved:
Other than that i think this can be merged, thanks again for taking the time to add this feature! PS: Also thank you for updating the docs and using the correct commit message style;) |
Thanks for the detailed feeback! I should hopefully have time this week to work updating the PR per your comments. |
Updated the PR per your feedback. Some notes below:
|
Very nice, thanks again for your effort!:) |
This PR adds a method for adding new tracks to the Rekordbox 6 database. It seems to be working on MacOS, but I haven't testetd it on Windows.
The new method doesn't set any of the track metadata information. The new track just shows up in Rekordbox with blank values for Title, Artist, Album, etc. However, Rekordbox is able to pull in all that information (including creating any related data like DjmdArtist) if you right click on the track in rb and select "Reload Tag."
Would you be apposed to adding
mutagen
as a dependency so we can populate the track metadata when it's created bypyrekordbox
?I'm also still not 100% sure about the
ContentLink
value. It seems to be a reference to therb_local_usn
from theTRACK
DjmdMenuItem. That value matches for new tracks that I add manually to Rekordbox, but there are older tracks in my library with aContentLink
value that doesn't seem to point to anything.Once this functionality is finalized and approved I'll update the relevant documentation.